Add new Thunderpack v1.1: STM32F411

[jgillick]

Summary

Adds the new Thunderpack board (v1.1), which replaces the STM32L07 chip from v1 with an STM32F411.

Version 1.1 branch of the project: https://github.com/jgillick/ThunderPack/tree/STM32F4

[fpistm]

Hi @jgillick
thanks for update.
Please fix the astyle issue:

diff --git a/variants/THUNDERPACK_F411/variant.cpp b/variants/THUNDERPACK_F411/variant.cpp
index 2e1c0a2..7ea64d8 100644
--- a/variants/THUNDERPACK_F411/variant.cpp
+++ b/variants/THUNDERPACK_F411/variant.cpp
@@ -101,8 +101,8 @@ WEAK void SystemClock_Config(void)
   }
 
   // Select PLL as system clock source and configure the HCLK, PCLK1 and PCLK2 clocks dividers
-  RCC_ClkInitStruct.ClockType = RCC_CLOCKTYPE_HCLK|RCC_CLOCKTYPE_SYSCLK
-                                |RCC_CLOCKTYPE_PCLK1|RCC_CLOCKTYPE_PCLK2;
+  RCC_ClkInitStruct.ClockType = RCC_CLOCKTYPE_HCLK | RCC_CLOCKTYPE_SYSCLK
+                                | RCC_CLOCKTYPE_PCLK1 | RCC_CLOCKTYPE_PCLK2;
   RCC_ClkInitStruct.SYSCLKSource = RCC_SYSCLKSOURCE_PLLCLK;
   RCC_ClkInitStruct.AHBCLKDivider = RCC_SYSCLK_DIV1;
   RCC_ClkInitStruct.APB1CLKDivider = RCC_HCLK_DIV2;

[fpistm]

Could you also update this file:
https://github.com/stm32duino/Arduino_Core_STM32/blob/master/CI/build/conf/cores_config.json

to ignore both THUNDERPACK as you rename one and create a new one.

Thanks.

[fpistm]

I think it is possible to merge both in the same variant directory.
I will propose you a version.

[fpistm]

Hi @jgillick
I've updated your branch with some fixes and also a merge of both variant.
Please, could you test on your side and give me your feedback?
Thanks

[jgillick]

@fpistm Your changes work great on both boards. I also made an additional small commit to remove an unused macro.

[fpistm]

I though you have a HSE at 24 MHz. I saw it on your schematics.
By default it is 25 8MHz so if it is not this value it have to be define.

[fpistm]

From here

And by default HSE_VALUE is 8 MHz:

Arduino_Core_STM32/system/STM32F4xx/stm32f4xx_hal_conf_default.h

Line 98 in 0f24f28

#define HSE_VALUE 8000000U /*!< Value of the External oscillator in Hz */

[fpistm]

@jgillick
any update on HSE value ?

[jgillick]

Ah, you're absolutely right, thanks for the correction I've reverted that commit.

[matthijskooijman]

@jgillick I'm working on some USB refactoring. Can you tell me if there is an external 1.5k pullup on the board? Or are you relying on the internal pullup (which would be better AFAICS)?

[fpistm]

@matthijskooijman
I think no, there is only an ESD protection:

[matthijskooijman]

Ok, great! I couldn't find any schematic to confirm yesterday, but this looks good. Thanks, I'll update my commit I'm about to push accordingly.

[fpistm]

here:

https://github.com/jgillick/ThunderPack/blob/master/hardware/Standard_18650/schematic.pdf

Even if it is F412 this is the same.

[jgillick]

Yes, that's the correct schematic. I clearly need to update the chip reference, but the rest of the circuit is the same.