Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flash latency for F4x5RG running full speed at 168MHz #1174

Merged
merged 1 commit into from Sep 15, 2020
Merged

Fix flash latency for F4x5RG running full speed at 168MHz #1174

merged 1 commit into from Sep 15, 2020

Conversation

geosmall
Copy link
Contributor

@geosmall geosmall commented Sep 14, 2020

Change 2 instances:

From:
HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_1)
To:
HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_5)

Summary
This PR fixes/implements the following bugs/features

[x] Bug 1 - incorrect FLASH LATENCY at 168MHz causing processor crash upon startup.

Also discussed here https://community.platformio.org/t/stm32duino-stm32f405rg-on-vesc-bldc-controller/14671

Change 2 instances:
HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_1)  --> HAL_RCC_ClockConfig(&RCC_ClkInitStruct, FLASH_LATENCY_5)
@fpistm fpistm added the Fix label Sep 15, 2020
@fpistm fpistm self-requested a review September 15, 2020 08:06
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Sep 15, 2020
@fpistm fpistm added this to the 2.0.0 milestone Sep 15, 2020
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geosmall
You're right not the correct value.

STM32 core based on ST HAL automation moved this from In progress to Reviewer approved Sep 15, 2020
@fpistm fpistm merged commit 0f155d0 into stm32duino:master Sep 15, 2020
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants