Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Java PATH problem (improved version) #1267

Closed

Conversation

dadul96
Copy link

@dadul96 dadul96 commented Dec 21, 2020

Summary

This change enables passing the Arduino IDE installation path to the maple_upload.bat-file in order to fix the Java PATH problem on Windows (see Issue in "stm32duino/Arduino_Tools": #67).
This PR only works in combination with the PR in "stm32duino/Arduino_Tools": #68.

Test/Verification

The whole fix has been verified by me and was also successfully merged into the Arduino_STM32-repository of Roger Clark. (See: merged PR)

This change allows passing the Arduino IDE installation path to the maple_upload.bat file in order to fix the Java PATH problem on Windows.
@fpistm
Copy link
Member

fpistm commented Apr 15, 2021

Hi @dadul96
I close this PR as it does not ensure not covered all possible case. Moreover it brings new issue see rogerclarkmelbourne/Arduino_STM32#846.
See also my comment in stm32duino/Arduino_Tools#67

@fpistm fpistm closed this Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants