Add support for generic STM32G030F6 #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABOSTM
requested changes
Dec 13, 2021
There was a problem hiding this comment.
@ademuri
Thanks for this Pull Request. As said @fpistm, it would be better to redefine the generic clock config to benefit from better performances
https://github.com/stm32duino/wiki/wiki/Add-a-new-variant-(board)#3---generic-system-clock-configuration
otherwise you stuck on default reset clock (which is slow).
|
Updated the clock. |
ABOSTM
requested changes
Dec 15, 2021
There was a problem hiding this comment.
Almost good.
See inline comment.
Also could you run Astyle to fix CI issue:
https://github.com/stm32duino/wiki/wiki/Astyle
Co-authored-by: Alexandre Bourdiol <50730894+ABOSTM@users.noreply.github.com>
fpistm
reviewed
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for generic
STM32G030F6-based boards. I have a custom board which uses this processor. I partially tested theCheckVariantsketch - I verified that the LED blinks slowly, but did not check the serial output.