Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add STM32G031FxPx (and STM32G031Y8Yx, STM32G041F6Px, STM32G041F8Px STM32G041Y8Yx) #1655

Merged
merged 8 commits into from
Feb 15, 2022

Conversation

olikraus
Copy link
Contributor

@olikraus olikraus commented Feb 10, 2022

This PR adds STM32G031FxPx devices to the boards.txt file.

The STM32G031FxPx TSSOP20 variant was missing. I think this is a nice and powerful variant for small DIY projects. More pins than the SO8, but easier to solder compared to the LQFP variants.

@fpistm fpistm requested a review from ABOSTM February 11, 2022 08:17
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Feb 11, 2022
@fpistm fpistm added this to the 2.3.0 milestone Feb 11, 2022
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olikraus,
Thanks for this PR.
Generally we follow this wiki to add new variant: https://github.com/stm32duino/wiki/wiki/Add-a-new-variant-%28board%29
There there are different things missing in your PR:

  • instead of adding only 3 new generic, (G031F4Px, G031F6Px and G031F8Px) you can copy/paste boards_entry.txt (which contains 7 new generic variant)
  • you need to add the new variants to README.md
  • for the new variant, we need a linker script : ldscript.ld
    and a Generic System Clock configuration.

STM32 core based on ST HAL automation moved this from In progress to Needs review Feb 11, 2022
@olikraus
Copy link
Contributor Author

Oh, nice, I didn't know that wiki page. I will go through the wiki and try to provide missing information.

@olikraus
Copy link
Contributor Author

ok, I fixed boards.txt and added ldscript.ld.

instead of adding only 3 new generic, (G031F4Px, G031F6Px and G031F8Px) you can copy/paste boards_entry.txt (which contains 7 new generic variant

Done for G031FxPx

you need to add the new variants to README.md

Done

for the new variant, we need a linker script : ldscript.ld

Done

Generic System Clock configuration

I think the default clock configuration was already there and is fine from my point of view. At least no changes required.

I also did a successful test with my own STM32G031F8Px board.

Note: cores_config_ci.json and cores_config.json not yet updated.

@olikraus
Copy link
Contributor Author

olikraus commented Feb 12, 2022

To be consistent with J and K variants I took over the clock setup from K variant. If I understood the code correctly the PLL output will be 64 MHz.

Test ok on my own board.

@fpistm fpistm requested a review from ABOSTM February 14, 2022 09:11
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olikraus
Thanks for this update.
To be complete, you could add the missing board sharing the same directory

@olikraus
Copy link
Contributor Author

olikraus commented Feb 14, 2022

You mean the G041F and G041Y variants?
Will do so...

@ABOSTM
Copy link
Contributor

ABOSTM commented Feb 14, 2022

Sorry, part of my comment did come up.
I mean add all the variants sharing the same directory. So yes G031Y8Yx, G041F6Px, G041F8Px G041Y8Yx
you can copy/paste boards_entry.txt (which contains 7 new generic variant)
Don't forget to update README.md accordingly.
Thanks

@olikraus olikraus changed the title add STM32G031FxPx add STM32G031FxPx (and STM32G031Y8Yx, STM32G041F6Px, STM32G041F8Px STM32G041Y8Yx) Feb 14, 2022
@olikraus
Copy link
Contributor Author

you can copy/paste boards_entry.txt (which contains 7 new generic variant)

Done

Don't forget to update README.md accordingly.

Done

Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olikraus thanks.

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Feb 15, 2022
@fpistm fpistm merged commit 443b609 into stm32duino:main Feb 15, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants