-
Notifications
You must be signed in to change notification settings - Fork 944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add STM32G031FxPx (and STM32G031Y8Yx, STM32G041F6Px, STM32G041F8Px STM32G041Y8Yx) #1655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olikraus,
Thanks for this PR.
Generally we follow this wiki to add new variant: https://github.com/stm32duino/wiki/wiki/Add-a-new-variant-%28board%29
There there are different things missing in your PR:
- instead of adding only 3 new generic, (G031F4Px, G031F6Px and G031F8Px) you can copy/paste boards_entry.txt (which contains 7 new generic variant)
- you need to add the new variants to README.md
- for the new variant, we need a linker script : ldscript.ld
and a Generic System Clock configuration.
Oh, nice, I didn't know that wiki page. I will go through the wiki and try to provide missing information. |
ok, I fixed boards.txt and added ldscript.ld.
Done for G031FxPx
Done
Done
I think the default clock configuration was already there and is fine from my point of view. At least no changes required. I also did a successful test with my own STM32G031F8Px board. Note: cores_config_ci.json and cores_config.json not yet updated. |
To be consistent with J and K variants I took over the clock setup from K variant. If I understood the code correctly the PLL output will be 64 MHz. Test ok on my own board. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olikraus
Thanks for this update.
To be complete, you could add the missing board sharing the same directory
You mean the G041F and G041Y variants? |
Sorry, part of my comment did come up. |
Done
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olikraus thanks.
This PR adds STM32G031FxPx devices to the boards.txt file.
The STM32G031FxPx TSSOP20 variant was missing. I think this is a nice and powerful variant for small DIY projects. More pins than the SO8, but easier to solder compared to the LQFP variants.