Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Agafia SG0 Board #1690

Merged
merged 6 commits into from
May 12, 2022
Merged

Added new Agafia SG0 Board #1690

merged 6 commits into from
May 12, 2022

Conversation

Khelicon
Copy link
Contributor

AGAFIA SG0 is the custom board based on STM32G071CB.

This PR fixes/implements the following bugs/features

  • Adding a new variant for Generic G071CBT

AGAFIA SG0 board is based on STM32G071CB
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Apr 19, 2022
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harji2130

Thank you for your contribution and Well formed PR.
CI will be launched when you will update your PR based on our comments.

README.md Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from In progress to Needs review Apr 19, 2022
@fpistm
Copy link
Member

fpistm commented Apr 29, 2022

Hi @harji2130
any update on this ?

@Khelicon
Copy link
Contributor Author

Hi @fpistm, I will have the changes updated by mid of next week.

@fpistm
Copy link
Member

fpistm commented Apr 29, 2022

OK @harji2130. Thank you for the update. No problem.
I've asked because I will prepare soon the next release.

@Khelicon Khelicon force-pushed the AgafiaSG0 branch 2 times, most recently from c44c60e to 4171f79 Compare May 4, 2022 01:46
@Khelicon
Copy link
Contributor Author

Khelicon commented May 5, 2022

Hi @fpistm, I have made the changes as per your suggestions.

- Correct case sensitive issue with filename
- Add linker script
- Add missing ALTx pin declaration
- apply astyle
- some clean up
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @harji2130
I've corrected several things, please refers to the PR I had submitted here:
SigmaIC#1

If yo merge it it will update this PR.

fix: variant declaration
fpistm and others added 2 commits May 6, 2022 10:05
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fix(agafia): linker script typo
@fpistm fpistm added this to the 2.3.0 milestone May 12, 2022
STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved May 12, 2022
@fpistm fpistm merged commit 0b6efb3 into stm32duino:main May 12, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Done May 12, 2022
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Jun 3, 2022
Since stm32duino#1690, generic should be added

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
cparata pushed a commit to cparata/Arduino_Core_STM32 that referenced this pull request Jan 31, 2023
* Added new Agafia SG0 Board

AGAFIA SG0 board is based on STM32G071CB

Signed-off-by: arsimranjit Sindhar <harsimransindhar@gmail.com> 
Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
cparata pushed a commit to cparata/Arduino_Core_STM32 that referenced this pull request Jan 31, 2023
Since stm32duino#1690, generic should be added

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants