Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags about fpv4 for cortex-m33 on platformio-build.py #1704

Merged
merged 1 commit into from
May 3, 2022
Merged

Add flags about fpv4 for cortex-m33 on platformio-build.py #1704

merged 1 commit into from
May 3, 2022

Conversation

asukiaaa
Copy link
Contributor

@asukiaaa asukiaaa commented May 3, 2022

I tried to build FreeRTOS for STM32L552ZE-Q with using PlatformIO bud failed.
stm32duino/STM32FreeRTOS#51
However, it succeeds on Arduino IDE.

I see log of them and I found that PlatformIO does not add the following flags for arm-none-eabi-gcc and arm-none-eabi-g++.

-mfpu=fpv4-sp-d16
-mfloat-abi=hard

The modification of this PR allow building FreeRTOS for STM32L552ZE-Q on PlatformIO.
Thank you.

@asukiaaa asukiaaa mentioned this pull request May 3, 2022
Closed
fpistm
fpistm reviewed May 3, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valeros, please could you check this and provide your feedback?

@valeros
Copy link
Contributor

valeros commented May 3, 2022

@asukiaaa Thanks for the PR!
@fpistm Thanks for pinging me, please merge.

@fpistm
Copy link
Member

fpistm commented May 3, 2022 •
edited

@valeros Thanks for the quick feedback and thanks @asukiaaa for this PR.

@fpistm fpistm added this to the 2.3.0 milestone May 3, 2022
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation May 3, 2022
@fpistm fpistm merged commit 949ecc8 into stm32duino:main May 3, 2022
STM32 core based on ST HAL automation moved this from In progress to Done May 3, 2022
@asukiaaa asukiaaa deleted the feature/support-fpv4-for-cortex-m33 branch May 3, 2022 15:24
@asukiaaa
Copy link
Contributor Author

asukiaaa commented May 3, 2022

Thank you for checking and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm left review comments

Assignees
No one assigned
Labels
Enhancement
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asukiaaa @valeros @fpistm