Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning the build process #1708

Merged
merged 2 commits into from
May 11, 2022
Merged

Cleaning the build process #1708

merged 2 commits into from
May 11, 2022

Conversation

massonal
Copy link
Contributor

@massonal massonal commented May 4, 2022

Summary

This PR implements the following improvements:

  • Cleaning the build flags: some flags in the compile step act on linking, and are therefore useless.
  • Reducing dependencies: a couple of files in the core depend on symbols defined in SrcWrapper. Moving them there makes for a simpler dependency graph (breaks a cycle of dependencies).

None of these changes fixes a bug, nor do they introduce new features. They just make for a simpler, cleaner, (faster?) build process.

@fpistm fpistm self-requested a review May 4, 2022 12:40
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation May 4, 2022
@fpistm fpistm marked this pull request as draft May 4, 2022 12:41
@massonal
build: remove -nostdlib from CFLAGS/CXXFLAGS
5831aee 
This argument impacts the linking, and has therefore no effect
at compile-time. It is harmless there, but also useless, and so
can be removed.
@massonal
refactor: moved files from core to SrcWrapper
87896b8 
- HardwareTimer.cpp
- new.cpp

These files were the only two in the core that had dependencies in
SrcWrapper. Moving them there will therefore ease the linking step
by removing needless dependencies between the different blocks.
@fpistm fpistm marked this pull request as ready for review May 4, 2022 19:11
@fpistm fpistm requested a review from ABOSTM May 5, 2022 08:19
fpistm
fpistm reviewed May 5, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests will be done with external libraries (STM32Ethernet,...)
Waiting @ABOSTM

ABOSTM
ABOSTM approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32 core based on ST HAL automation moved this from In progress to Reviewer approved May 10, 2022
@fpistm
Copy link
Member

fpistm commented May 11, 2022

Tested with some libraries. All seems correct.

@fpistm fpistm merged commit 6ba929e into stm32duino:main May 11, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Done May 11, 2022
@fpistm fpistm added this to the 2.3.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm left review comments

@ABOSTM ABOSTM ABOSTM approved these changes

Assignees
No one assigned
Labels
Arduino compatibility Enhancement Fix
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@massonal @fpistm @ABOSTM