Add support to CRC peripheral by default #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
reviewed
May 12, 2022
| @@ -19,6 +19,8 @@ | |||
| extern "C" { | |||
| #endif | |||
|
|
|||
| CRC_HandleTypeDef hcrc = {.Instance = CRC}; | |||
There was a problem hiding this comment.
Suggested change
| CRC_HandleTypeDef hcrc = {.Instance = CRC}; | |
| #ifdef CRC2_BASE | |
| #define CRC_INSTANCE CRC2 | |
| #elif defined(CRC_BASE) | |
| #define CRC_INSTANCE CRC | |
| #else | |
| #error "No CRC instance available" | |
| #endif | |
| CRC_HandleTypeDef hcrc = {.Instance = CRC_INSTANCE}; |
fpistm
requested changes
May 12, 2022
| @@ -19,6 +19,8 @@ | |||
| extern "C" { | |||
| #endif | |||
|
|
|||
| CRC_HandleTypeDef hcrc = {.Instance = CRC}; | |||
There was a problem hiding this comment.
Suggested change
| CRC_HandleTypeDef hcrc = {.Instance = CRC}; | |
| #if defined(CRC_BASE) | |
| CRC_HandleTypeDef hcrc = {.Instance = CRC}; | |
| #endif |
STM32 core based on ST HAL
automation
moved this from Needs review
to Reviewer approved
May 12, 2022
fpistm
approved these changes
May 12, 2022
fpistm
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to add the CRC peripheral support by default in the Core. It could be useful to run some binary libraries like MotionFX.
Best Regards,
Carlo