Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

variant: G0: add Nucleo-G070RB #1745

Merged
merged 1 commit into from
Jun 21, 2022
Merged

variant: G0: add Nucleo-G070RB #1745

merged 1 commit into from
Jun 21, 2022

Conversation

TDhaouST
Copy link
Contributor

@TDhaouST TDhaouST commented Jun 20, 2022 •
edited by fpistm
Loading

Nucleo_g070rb

Tested:

  • GPIO
  • U(S)ART
  • ADC
  • DAC
  • I2C
  • SPI
  • Timer
  • RTC
  • Low Power
  • EEPROM

Fixes #1147 and fixes #1651

@fpistm fpistm requested review from ABOSTM and fpistm June 20, 2022 16:38
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Jun 20, 2022
@fpistm fpistm added this to the 2.3.0 milestone Jun 20, 2022
fpistm
fpistm requested changes Jun 20, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will deeply reviewed later. Here a first feedback.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
variants/STM32G0xx/G070RBT/generic_clock.c Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from In progress to Needs review Jun 20, 2022
@TDhaouST TDhaouST force-pushed the add-G070rb-variant branch 2 times, most recently from 2b7e3ef to a4f6eb5 Compare June 21, 2022 09:26
fpistm
fpistm approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Jun 21, 2022
This was referenced Jun 21, 2022
Closed
Closed
ABOSTM
ABOSTM requested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor comments

variants/STM32G0xx/G070RBT/variant_NUCLEO_G070RB.cpp Outdated Show resolved Hide resolved
variants/STM32G0xx/G070RBT/variant_NUCLEO_G070RB.h Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from Reviewer approved to Needs review Jun 21, 2022
@fpistm @TDhaouST
variant: G0: add Nucleo-G070RB
63bf4db 
Signed-off-by: TLIG Dhaou <dhaou.tlig-ext@st.com>
STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Jun 21, 2022
@fpistm fpistm merged commit 58264d2 into stm32duino:main Jun 21, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Jun 21, 2022
@fpistm fpistm mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

@ABOSTM ABOSTM ABOSTM approved these changes

Assignees

@TDhaouST TDhaouST

Labels
New variant
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.

Nucleo-G070RB [New Variant] add support for Nucleo64 STM32G070
3 participants
@TDhaouST @fpistm @ABOSTM