Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Nucleo F722ZE board #1831

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Add Nucleo F722ZE board #1831

merged 2 commits into from
Sep 16, 2022

Conversation

gautierg-st
Copy link
Contributor

Fixes #1259

Tested:

  • Serial
  • USB
  • I2C
  • SPI

@fpistm fpistm self-requested a review September 16, 2022 09:32
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Sep 16, 2022
@fpistm fpistm added this to the 2.4.0 milestone Sep 16, 2022
fpistm
fpistm requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first PR. Somes minor remarks.
Anyway it misses the generic declaration.

README.md Outdated Show resolved Hide resolved
variants/STM32F7xx/F722Z(C-E)T_F732ZET/variant_NUCLEO_F722ZE.h Outdated Show resolved Hide resolved
variants/STM32F7xx/F722Z(C-E)T_F732ZET/variant_NUCLEO_F722ZE.h Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from In progress to Needs review Sep 16, 2022
fpistm
fpistm requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It misses generic references in the README.md and the generic clock to add in the generic_clock.c (ex: https://github.com/stm32duino/Arduino_Core_STM32/pull/1712/files#diff-9c22d2f9bf0c6ada5a16b60c5dee88c8c2a5dbe87159623aea7fb4c3215dc56eL24)

fpistm
fpistm requested changes Sep 16, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round 😉
Else LGTM. Thanks.

README.md Outdated Show resolved Hide resolved
variants/STM32F7xx/F722Z(C-E)T_F732ZET/generic_clock.c Outdated Show resolved Hide resolved
@gautierg-st
Add some generic variants for STM32F7xx
0dec214 
Add the following generic variants:
- STM32F722ZCTx
- STM32F722ZETx
- STM32F732ZETx
@gautierg-st
Add Nucleo F722ZE board
a855f12 
Fixes stm32duino#1259

Tested:
- Serial
- USB
- I2C
- SPI
fpistm
fpistm approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Sep 16, 2022
@fpistm fpistm merged commit 7a9b96d into stm32duino:main Sep 16, 2022
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
New variant
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Nucleo 144 F722ZE
3 participants
@gautierg-st @nschurando @fpistm