Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Name Swan Virtual COM Port pins #1841

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Oct 3, 2022

Pull Request template

Please, Make sure that your PR is not a duplicate.
Search among the Pull request before creating one.

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Thanks for submitting a pull request.
Please provide enough information so that others can review your pull request:

Summary

This PR fixes/implements the following bugs/features

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

Validation

  • Ensure CI build is passed.
  • Demonstrate the code is solid. [e.g. Provide a sketch]

Code formatting

  • Ensure AStyle check is passed thanks CI

Closing issues

Fixes #xxx

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Anyway it is not a VCP, it is a real U(S)ART.

@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Oct 4, 2022
@fpistm fpistm added this to the 2.4.0 milestone Oct 4, 2022
@zfields
Copy link
Contributor Author

zfields commented Oct 4, 2022

The Swan has LPUART1 connected to the VCP port of the STLINK connector.

@fpistm fpistm merged commit 433f4fe into stm32duino:main Oct 4, 2022
STM32 core based on ST HAL automation moved this from In progress to Done Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants