Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to CMSIS 5.9.0 #2099

Merged
merged 4 commits into from
Aug 10, 2023
Merged

chore: update to CMSIS 5.9.0 #2099

merged 4 commits into from
Aug 10, 2023

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Aug 9, 2023

No more DSP libraries.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Aug 9, 2023
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member Author

fpistm commented Aug 9, 2023

Hi @valeros
Hope you are fine. I've updated the cmsis version but it seems pio does not like it. Any thoughts on this?

@valeros
Copy link
Contributor

valeros commented Aug 9, 2023

Hi @fpistm, thanks for pinging. It seems that the CMSIS package is not updated properly. I'm curious how you handle such updates. I've found the entrypoint.sh script that does some manipulations like downloading a CMSIS package, but I don't see any other actions besides extracting the CMSIS package to the home folder of the CI runner. Am I missing something?

@fpistm
Copy link
Member Author

fpistm commented Aug 9, 2023

It seems it is properly downloaded. With arduino, no issue. The file is properly built. Maybe GH action cache issue, but seems not the case.

@valeros
Copy link
Contributor

valeros commented Aug 9, 2023

It seems it is properly downloaded. With arduino, no issue. The file is properly built. Maybe GH action cache issue, but seems not the case.

I'm afraid it's not enough to simply extract the CMSIS package in the core folder, PlatformIO won't see this update as the CMSIS is a standalone package in the PlatformIO ecosystem. I see here two ways how to handle this:

  1. The easiest approach is to publish the new CMSIS 5.9.0 to the PlatformIO Registry and then dynamically replace the version field in the entrypoint.sh. A single drawback is that we'll lose the ability of replacing the CMSIS package with arbitrary versions directly from the https://github.com/stm32duino/ArduinoModule-CMSIS
  2. We keep the current workflow with downloading the CMSIS package from https://github.com/stm32duino/ArduinoModule-CMSIS, but introduce some additional logic that will properly substitute the already downloaded CMSIS with a new one.

Let me know, what's more suitable for you.

@fpistm
Copy link
Member Author

fpistm commented Aug 10, 2023

Hi @valeros
OK understood. I thought it already uses the downloaded one. Seems this download was not useful 😉
So I guess option 2 is the best way else we will got this issue again in the next update.

@fpistm fpistm merged commit ac91c49 into stm32duino:main Aug 10, 2023
22 of 23 checks passed
STM32 core based on ST HAL automation moved this from In progress to Done Aug 10, 2023
@fpistm fpistm deleted the CMSIS_5.9.0 branch August 10, 2023 13:49
@fpistm
Copy link
Member Author

fpistm commented Aug 10, 2023

PIO build will be managed later.

@fpistm fpistm added this to the 2.7.0 milestone Aug 10, 2023
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this pull request Aug 10, 2023
Since stm32duino#2099, pio build failed as it does not used the
specified CMSIS version.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm added a commit that referenced this pull request Aug 10, 2023
Since #2099, pio build failed as it does not used the
specified CMSIS version.

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants