Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add variant: Generic H503KBU #2423

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Add variant: Generic H503KBU #2423

merged 2 commits into from
Jul 9, 2024

Conversation

dojyorin
Copy link
Contributor

@dojyorin dojyorin commented Jul 6, 2024 •
edited by fpistm
Loading

I'm sorry for inconvenience caused with PR:Nucleo-H503RB.
Could you please make sure added and modified code?

I set clock configuration in STM32CubeMX as described on Wiki, but peripheral configuration were not present in code.
(e.g. PeriphClkInitStruct.UsbClockSelection = RCC_USBCLKSOURCE_HSI48)
Looking at CubeMX clock configuration GUI, for example, USB uses HSI48 by default, so does that mean no additional configurations are required?

Summary

This PR implements the following features

  • New variant: Generic STM32H503KBU

@dojyorin
Add variant: H503KBU (#1)
92a5fcd 
* add board definition.

* copy ldscript.

* change name.

* copy clock config.

* add generic clock.

* variable size.

* add support list.
@dojyorin dojyorin mentioned this pull request Jul 6, 2024
Merged
1 task
@dojyorin dojyorin changed the title Add variant: H503KBU Add variant: Generic H503KBU Jul 6, 2024
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Jul 8, 2024
fpistm
fpistm requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo to fix and it is ok for me.
About Periphjeral clock config, no need to specify it as HSI48 is the default entry.

README.md Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from In progress to Needs review Jul 8, 2024
@dojyorin @fpistm
Update README.md
970d88f 
Accept version fix.

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Kazuki Ota <ota_droid@live.jp>
@dojyorin
Copy link
Contributor Author

dojyorin commented Jul 8, 2024

About Periphjeral clock config, no need to specify it as HSI48 is the default entry.

Thank you for teaching me.
Version fix suggestion was accepted.

@dojyorin dojyorin requested a review from fpistm July 8, 2024 17:58
fpistm
fpistm approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

STM32 core based on ST HAL automation moved this from Needs review to Reviewer approved Jul 9, 2024
@fpistm fpistm added this to the 2.8.1 milestone Jul 9, 2024
@fpistm fpistm merged commit 0f1ee4d into stm32duino:main Jul 9, 2024
24 checks passed
STM32 core based on ST HAL automation moved this from Reviewer approved to Done Jul 9, 2024
@dojyorin dojyorin deleted the variant-h503kbu branch July 10, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
New variant
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dojyorin @fpistm