Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Malyan 3d printer variants #382

Closed
wants to merge 22 commits into from

Conversation

xC0000005
Copy link
Contributor

This adds the variants for Malyan's M200 v1 (an STM32F103 printer) and M200 v2 (STM32F070 printer). It may also work with the MP Mini Delta and Malyan M100, but those are untested. I didn't mean to add the package.json, but I can't figure out how to remove it from the PR (sorry). It's only needed for PlatformIO to download a package.

@fpistm fpistm self-requested a review November 27, 2018 19:45
@fpistm fpistm added this to In progress in STM32 core based on ST HAL via automation Nov 27, 2018
@fpistm
Copy link
Member

fpistm commented Nov 27, 2018

Hi @xC0000005
Thanks for the contributions.
I will review it soon.
About package.json
You can rebase the PR branch then remove the commit.
git rebase -i <sha1 before the commit which add the package.json>
then delete line with the "Add package.json" commit and save

@xC0000005
Copy link
Contributor Author

I'm working on figuring out how to rebase this (sorry for the messy history).

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a well formed PR.
See my comments/questions.
Thanks in advance

boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
variants/MALYANM200_F070CB/PeripheralPins.c Show resolved Hide resolved
variants/MALYANM200_F070CB/PinNamesVar.h Show resolved Hide resolved
variants/MALYANM200_F103CB/PeripheralPins.c Outdated Show resolved Hide resolved
variants/MALYANM200_F103CB/PeripheralPins.c Show resolved Hide resolved
variants/MALYANM200_F103CB/PinNamesVar.h Show resolved Hide resolved
variants/MALYANM200_F103CB/ldscript.ld Outdated Show resolved Hide resolved
variants/MALYANM200_F103CB/stm32f1xx_hal_conf.h Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
STM32 core based on ST HAL automation moved this from In progress to Needs review Dec 21, 2018
boards.txt Outdated Show resolved Hide resolved
@fpistm fpistm assigned fpistm and xC0000005 and unassigned fpistm Dec 21, 2018
@xC0000005
Copy link
Contributor Author

@fpistm - I've tested the updates on the M200 V1 and V2. If I've missed something, I'm happy to make adjustments, but I'm not sure what to do next.

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.
Only one small change to do and a question.
Then I will merge it after some build tests

const PinMap PinMap_USB[] = {
{PA_11, USB, STM_PIN_DATA(STM_MODE_INPUT, GPIO_NOPULL, GPIO_AF10_USB_FS)}, // USB_DM
{PA_12, USB, STM_PIN_DATA(STM_MODE_INPUT, GPIO_NOPULL, GPIO_AF10_USB_FS)}, // USB_DP
{PA_13, USB, STM_PIN_DATA(STM_MODE_AF_PP, GPIO_PULLUP, GPIO_AF10_USB_FS)}, // USB_NOE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is NOE used? If not then you can comment it to avoid init this pin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update on NOE usage ?

variants/MALYANM200_F070CB/PeripheralPins.c Show resolved Hide resolved
variants/MALYANM200_F070CB/PeripheralPins.c Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
@xC0000005
Copy link
Contributor Author

xC0000005 commented Jan 28, 2019 via email

@fpistm
Copy link
Member

fpistm commented Jan 28, 2019

I just rebased this last night - oh, I forgot to push. Hopefully git does the right thing and figures it out.

:D
Ok will update

package.json Show resolved Hide resolved
@xC0000005
Copy link
Contributor Author

xC0000005 commented Jan 28, 2019 via email

boards.txt Show resolved Hide resolved
@fpistm
Copy link
Member

fpistm commented Jan 28, 2019

I will do a clean before merge.

@xC0000005
Copy link
Contributor Author

xC0000005 commented Jan 28, 2019 via email

@fpistm
Copy link
Member

fpistm commented Jan 28, 2019

This PR has been rebased and cleaned in #422

@xC0000005
Copy link
Contributor Author

xC0000005 commented Jan 28, 2019 via email

@fpistm fpistm closed this in #422 Jan 29, 2019
STM32 core based on ST HAL automation moved this from Needs review to Done Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants