Fixed missing parentheses and added STM32F042x6 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LMESTM
approved these changes
Jul 19, 2017
|
any updates to this? Want to use the stm32 core in a workshop, but would be easier if this fix/change is integrated in a new release. |
ghost
reviewed
Jul 27, 2017
| @@ -49,7 +49,7 @@ uint32_t pinNametoDigitalPin(PinName p); | |||
| // Convert an analog pin number Axx to a PinName Pxy | |||
| #define analogInputToPinName(p) (digitalPinToPinName(analogInputToDigitalPin(p))) | |||
| // All pins could manage EXTI | |||
| #define digitalPinToInterrupt(p) ((digitalPinIsValid(p) ? p : NOT_AN_INTERRUPT) | |||
| #define digitalPinToInterrupt(p) ((digitalPinIsValid(p) ? p : NOT_AN_INTERRUPT)) | |||
There was a problem hiding this comment.
Delete the first parenthesis works too and it makes the code more readable.
There was a problem hiding this comment.
yes, that works better :)
|
@tomvdb |
ghost
added
the
|
Hi, @tomvdb, thanks for the fix. I'm on vacation until 31th july. I will do a release with F401 RE next week. |
|
I've manually merged the PR with minor corrections |
|
Thanks! Sorry, still meant to fix the suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an error in pins_arduino.h. The macro is missing a bracket.
digitalPinToInterrupt(p) ((digitalPinIsValid(p) ? p : NOT_AN_INTERRUPT)
I also added the STM32F042x6 startup file define in stm32_def_build.h