harden prediv management and add parameter to set binary mode #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
force-pushed
the
prediv
branch
2 times, most recently
from
ee39147
to
0385636
Compare
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
else this prevent isConfigured(void) to return correct value. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
prediv was not properly computed and some misalignment's could occur depending of the RTC state at init. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
(a)synchronous prescalers values depend on the RTC clock source. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
This is valid when the RTC_BINARY_MIX mode exists in the RTC (bitfield in the RTC ICSR register) Set the RTC mode through a setBinaryMode function to be called before begin. Signed-off-by: Francois Ramu <francois.ramu@st.com> Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Formatted with Arduino astyle. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: harden prediv management vs clock config
prediv was not properly computed and some misalignment's could occur depending of the RTC state at init.
feat: add a parameter to set binary mode
This is valid when the RTC_BINARY_MIX mode exists in the RTC (bitfield in the RTC ICSR register)
Set the RTC mode through a setBinaryMode function to be called before begin.