Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass payload during bios reset #268

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

kourtneyboss
Copy link
Contributor

ResetBios fails with a nil payload. An empty payload is accepted.

Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, and no one has come along raising any issues. The chance of that happening might be better if it's actually part of the codebase, so let's merge it and watch for anyone having problems.

I don't personally have the hardware to test this against a variety of systems, so unfortunately we will have to use the real world as a test. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants