Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAL_FDCAN_GetRxMessage doesn't check for buffer size #4

Closed
Chris-Idema-WizzDev opened this issue Jan 18, 2022 · 2 comments
Closed

HAL_FDCAN_GetRxMessage doesn't check for buffer size #4

Chris-Idema-WizzDev opened this issue Jan 18, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system

Comments

@Chris-Idema-WizzDev
Copy link

HAL_StatusTypeDef HAL_FDCAN_ActivateNotification(FDCAN_HandleTypeDef *hfdcan, uint32_t ActiveITs,

HAL_FDCAN_GetRxMessage doesn't check for buffer size. Since there is no function in this header file to request the size of the message before reading you are forced to allocate an array of 64 bytes to be sure. A bounds check would prevent buffer overflow and reading the size of the message before copying it would be helpful too,

@ASELSTM
Copy link
Collaborator

ASELSTM commented Feb 9, 2022

ST Internal Reference: 122463

@ASELSTM ASELSTM added internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system hal HAL-LL driver-related issue or pull-request. labels Feb 9, 2022
@ASELSTM ASELSTM moved this from To do to In progress in stm32cube-mcu-hal-dashboard Feb 9, 2022
@ALABSTM ALABSTM added the enhancement New feature or request label Jan 4, 2024
@ALABSTM ALABSTM assigned RJMSTM and unassigned ASELSTM Jan 4, 2024
@RJMSTM
Copy link
Contributor

RJMSTM commented Feb 14, 2024

Hello,

I hope you are fine. The issue you reported has been fixed in the frame of version v1.2.3 of the STM32CubeG4 published recently on GitHub. Thank you again for having reported.

Thank you again for your contribution.
With regards,

@RJMSTM RJMSTM closed this as completed Feb 14, 2024
stm32cube-mcu-hal-dashboard automation moved this from In progress to Done Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system
Development

No branches or pull requests

4 participants