This repository has been archived by the owner on Sep 6, 2023. It is now read-only.
3/set up and scaffold (second attempt) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from emmanuelroussel/stockpile-app.
Copied from Cinema Leagues and lightly edited.
… into 3/set-up-and-scaffold
The build is failing because the environment variables file was not found on the build server. Since the actual variables are set in the Travis CI environment and not a file, it should fix the problem to copy the example environment variables file and allow empty values.
This allows remote access to the database instead of assuming that it will always be available on localhost.
This should have been added when the same option was added in `index.js`.
This should have been added when this environment variable was added in the database service.
When the test fails, it does not clean up after itself, so the test must drop its table (if it exists) before trying to create a new one.
The command added to the Travis CI configuration depends on existing coverage output generated by `nyc`. Adding `nyc` to the test script creates that output.
Since tests are written in ES2015+, they are not guaranteed to work with all Code Climate engines.
|
Your pull request doesn't follow our guidelines. Please fix the following:
Click here for details. Thank you! 🙏 |
Closed
|
Changes Unknown when pulling deb3ee7 on 3/set-up-and-scaffold into ** on master**. |
emroussel
suggested changes
Jan 29, 2017
|
@emmanuelroussel Good call. I added the issue to the body of the PR. And yes, see #5, I am planning to add tests for the database service in there (trying to keep this PR focused on environment setup). |
emroussel
approved these changes
Jan 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the one to actually review.
Closes #10.