Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ggatyear() layout issues #204

Closed
BBieri opened this issue Feb 28, 2022 · 4 comments · Fixed by #210
Closed

Fix ggatyear() layout issues #204

BBieri opened this issue Feb 28, 2022 · 4 comments · Fixed by #210
Assignees
@BBieri
Labels
bug Something isn't working

Comments

@BBieri
Copy link
Collaborator

BBieri commented Feb 28, 2022 •
edited

ggatyear() does not find the specified "dynamic" layout.
@BBieri BBieri added the bug Something isn't working label Feb 28, 2022
@BBieri BBieri self-assigned this Feb 28, 2022
@jhollway
Copy link
Collaborator

Can you please describe these issues?

@BBieri
Copy link
Collaborator Author

BBieri commented Mar 1, 2022

Sure! Here is a reprex illustrating the issue. Basically, the function does not find the correct layout.

# Get the data
membs <- manyenviron::memberships$IEADB_MEM

# Plot things
migraph::ggatyear(membs, 2010)
#> Registered S3 methods overwritten by 'migraph':
#>   method           from
#>   plot.blockmodel  sna 
#>   print.blockmodel sna
#> Warning in igraph::graph_from_data_frame(object): In `d' `NA' elements were
#> replaced with string "NA"
#> Error in get(paste0("layout_tbl_graph_", layout)): object 'layout_tbl_graph_dynamic' not found

Created on 2022-03-01 by the reprex package (v2.0.1)

Session info 
sessioninfo::session_info()
#> - Session info ---------------------------------------------------------------
#>  setting  value
#>  version  R version 4.1.2 (2021-11-01)
#>  os       Windows 10 x64 (build 22000)
#>  system   x86_64, mingw32
#>  ui       RTerm
#>  language (EN)
#>  collate  English_Switzerland.1252
#>  ctype    English_Switzerland.1252
#>  tz       Europe/Berlin
#>  date     2022-03-01
#>  pandoc   2.11.4 @ C:/Program Files/RStudio/bin/pandoc/ (via rmarkdown)
#> 
#> - Packages -------------------------------------------------------------------
#>  package        * version date (UTC) lib source
#>  assertthat       0.2.1   2019-03-21 [1] CRAN (R 4.1.0)
#>  backports        1.4.1   2021-12-13 [1] CRAN (R 4.1.2)
#>  cellranger       1.1.0   2016-07-27 [1] CRAN (R 4.1.0)
#>  cli              3.1.1   2022-01-20 [1] CRAN (R 4.1.2)
#>  coda             0.19-4  2020-09-30 [1] CRAN (R 4.1.0)
#>  colorspace       2.0-2   2021-06-24 [1] CRAN (R 4.1.1)
#>  concaveman       1.1.0   2020-05-11 [1] CRAN (R 4.1.1)
#>  crayon           1.4.2   2021-10-29 [1] CRAN (R 4.1.1)
#>  DBI              1.1.2   2021-12-20 [1] CRAN (R 4.1.2)
#>  digest           0.6.29  2021-12-01 [1] CRAN (R 4.1.2)
#>  dplyr            1.0.7   2021-06-18 [1] CRAN (R 4.1.2)
#>  ellipsis         0.3.2   2021-04-29 [1] CRAN (R 4.1.0)
#>  evaluate         0.14    2019-05-28 [1] CRAN (R 4.1.0)
#>  fansi            0.5.0   2021-05-25 [1] CRAN (R 4.1.0)
#>  farver           2.1.0   2021-02-28 [1] CRAN (R 4.1.0)
#>  fastmap          1.1.0   2021-01-25 [1] CRAN (R 4.1.0)
#>  fs               1.5.2   2021-12-08 [1] CRAN (R 4.1.2)
#>  generics         0.1.2   2022-01-31 [1] CRAN (R 4.1.2)
#>  ggdendro         0.1.22  2020-09-13 [1] CRAN (R 4.1.1)
#>  ggforce          0.3.3   2021-03-05 [1] CRAN (R 4.1.1)
#>  ggplot2          3.3.5   2021-06-25 [1] CRAN (R 4.1.1)
#>  ggraph           2.0.5   2021-02-23 [1] CRAN (R 4.1.1)
#>  ggrepel          0.9.1   2021-01-15 [1] CRAN (R 4.1.1)
#>  glue             1.6.0   2021-12-17 [1] CRAN (R 4.1.2)
#>  graphlayouts     0.8.0   2022-01-03 [1] CRAN (R 4.1.2)
#>  gridExtra        2.3     2017-09-09 [1] CRAN (R 4.1.0)
#>  gtable           0.3.0   2019-03-25 [1] CRAN (R 4.1.0)
#>  highr            0.9     2021-04-16 [1] CRAN (R 4.1.0)
#>  htmltools        0.5.2   2021-08-25 [1] CRAN (R 4.1.1)
#>  igraph           1.2.11  2022-01-04 [1] CRAN (R 4.1.2)
#>  knitr            1.37    2021-12-16 [1] CRAN (R 4.1.2)
#>  lattice          0.20-45 2021-09-22 [1] CRAN (R 4.1.2)
#>  lifecycle        1.0.1   2021-09-24 [1] CRAN (R 4.1.2)
#>  magrittr         2.0.1   2020-11-17 [1] CRAN (R 4.1.0)
#>  manyenviron      0.1.0   2022-01-31 [1] local
#>  MASS             7.3-55  2022-01-13 [1] CRAN (R 4.1.2)
#>  migraph          0.9.0   2022-03-01 [1] local
#>  munsell          0.5.0   2018-06-12 [1] CRAN (R 4.1.0)
#>  network          1.17.1  2021-06-14 [1] CRAN (R 4.1.1)
#>  oaqc             1.0     2017-11-14 [1] CRAN (R 4.1.1)
#>  pillar           1.7.0   2022-02-01 [1] CRAN (R 4.1.2)
#>  pkgconfig        2.0.3   2019-09-22 [1] CRAN (R 4.1.0)
#>  polyclip         1.10-0  2019-03-14 [1] CRAN (R 4.1.1)
#>  purrr            0.3.4   2020-04-17 [1] CRAN (R 4.1.0)
#>  R.cache          0.15.0  2021-04-30 [1] CRAN (R 4.1.2)
#>  R.methodsS3      1.8.1   2020-08-26 [1] CRAN (R 4.1.1)
#>  R.oo             1.24.0  2020-08-26 [1] CRAN (R 4.1.1)
#>  R.utils          2.11.0  2021-09-26 [1] CRAN (R 4.1.2)
#>  R6               2.5.1   2021-08-19 [1] CRAN (R 4.1.1)
#>  RColorBrewer     1.1-2   2014-12-07 [1] CRAN (R 4.1.0)
#>  Rcpp             1.0.7   2021-07-07 [1] CRAN (R 4.1.0)
#>  readxl           1.3.1   2019-03-13 [1] CRAN (R 4.1.0)
#>  reprex           2.0.1   2021-08-05 [1] CRAN (R 4.1.1)
#>  rlang            0.4.12  2021-10-18 [1] CRAN (R 4.1.1)
#>  rmarkdown        2.11    2021-09-14 [1] CRAN (R 4.1.1)
#>  rstudioapi       0.13    2020-11-12 [1] CRAN (R 4.1.0)
#>  scales           1.1.1   2020-05-11 [1] CRAN (R 4.1.0)
#>  sessioninfo      1.2.2   2021-12-06 [1] CRAN (R 4.1.2)
#>  sna              2.6     2020-10-06 [1] CRAN (R 4.1.1)
#>  statnet.common   4.5.0   2021-06-05 [1] CRAN (R 4.1.1)
#>  stringi          1.7.6   2021-11-29 [1] CRAN (R 4.1.2)
#>  stringr          1.4.0   2019-02-10 [1] CRAN (R 4.1.0)
#>  styler           1.6.2   2021-09-23 [1] CRAN (R 4.1.2)
#>  tibble           3.1.6   2021-11-07 [1] CRAN (R 4.1.2)
#>  tidygraph        1.2.0   2020-05-12 [1] CRAN (R 4.1.1)
#>  tidyr            1.2.0   2022-02-01 [1] CRAN (R 4.1.2)
#>  tidyselect       1.1.1   2021-04-30 [1] CRAN (R 4.1.0)
#>  tweenr           1.0.2   2021-03-23 [1] CRAN (R 4.1.1)
#>  utf8             1.2.2   2021-07-24 [1] CRAN (R 4.1.2)
#>  vctrs            0.3.8   2021-04-29 [1] CRAN (R 4.1.0)
#>  viridis          0.6.2   2021-10-13 [1] CRAN (R 4.1.2)
#>  viridisLite      0.4.0   2021-04-13 [1] CRAN (R 4.1.0)
#>  withr            2.4.3   2021-11-30 [1] CRAN (R 4.1.1)
#>  xfun             0.29    2021-12-14 [1] CRAN (R 4.1.2)
#>  yaml             2.2.1   2020-02-01 [1] CRAN (R 4.1.0)
#> 
#>  [1] C:/Users/bjorn/Documents/R/win-library/4.1
#>  [2] C:/Program Files/R/R-4.1.2/library
#> 
#> ------------------------------------------------------------------------------

@jhollway
Copy link
Collaborator

jhollway commented Mar 2, 2022

Why don't we instead create a new function that just selects a network from a particular year or wave if such information is included in the igraph/network object? Then that can just be passed directly on to autographr()

BBieri pushed a commit that referenced this issue Mar 7, 2022
Fixed #204 by switching ggatyear()'s plotting component to autographr()
747fca0
@BBieri
Copy link
Collaborator Author

BBieri commented Mar 7, 2022

Done. I simplified the function by using autographr() for the plots and tested the new function.

@jhollway jhollway mentioned this issue Mar 29, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BBieri BBieri

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Overhaul of network_reg() stocnet/migraph
2 participants
@jhollway @BBieri