Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added as_network and preparation for CRAN submission #86

Merged
merged 5 commits into from
Apr 11, 2021
Merged

Conversation

jhollway
Copy link
Collaborator

@jhollway jhollway commented Apr 11, 2021

Description

Package

  • Closed Submit to CRAN #21 by elaborating DESCRIPTION file in preparation for CRAN submission
  • Updated several old URLs in documentation

Classes

  • Closed Add sna integration #85 by adding as_network() to coerce objects into network class
  • Modified other coercion functions to also work with network class objects

Checklist:

  • PR form
    • I have given this pull request an informative title
    • Description above itemizes changes under subtitles, e.g. "## Collection""
    • Any closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"
    • Package builds on my OS without issues
  • PR checks all pass for latest commit
    • Package builds on Mac
    • Package builds on Windows
    • Package builds on Linux
    • CodeCov check: Package improves or maintains good test coverage
    • CodeFactor check: Package improves or maintains good style
  • Documentation
    • Any new or modified functions or data have roxygen style documentation in their .R scripts
    • Any longer functions are commented inline so that it is easier to debug in the future
    • PR description above and the NEWS.md file are aligned
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)

@jhollway jhollway merged commit b69dc38 into main Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sna integration Submit to CRAN
1 participant