Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: specify meeting that is multiple days away #221

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

ldennington
Copy link
Contributor

@ldennington ldennington commented Apr 2, 2024

Currently, the only dates permitted by this action are today and tomorrow. This prevents scenarios in which, for example, someone would like to create the issue on Monday and record ideas/topics throughout the week for a meeting on Friday.

Therefore, this change introduces the concept of x days from now. In addition to today and tomorrow, users can now specify, for example, 4 days from now for the scenario described above.

Changes is in this PR

  • Changes to lib/meeting.js to expand scheduling functionality, allowing for a meeting to be scheduled for any number of days from the current date, not just today or tomorrow.
  • Changes to readme.md to reflect these changes.

cc/ @stoe

@ldennington
Copy link
Contributor Author

@stoe - I've created this as a draft for now because I'm still working out how to test these updates. If you have any advice on that front, it would be much appreciated!

@stoe stoe added the feature-request 🚧 Want something new? label Apr 2, 2024
@stoe
Copy link
Owner

stoe commented Apr 2, 2024

👋 @ldennington

Thank you for your contribution. 🐙🐱💖

I will give it a more thorough look once I have more bandwidth, but at first glance it looks to do what you described.

@stoe
Copy link
Owner

stoe commented Apr 2, 2024

I've created this as a draft for now because I'm still working out how to test these updates. If you have any advice on that front, it would be much appreciated!

Testing has been on my personal backlog for quite some time, but if you want to give it a try, @ldennington, feel free to suggest something.

Currently, the only dates permitted by this action are 'today' and 'tomorrow'.
This prevents scenarios in which, for example, someone would like to create the
issue on Monday and record ideas/topics throughout the week for a meeting on
Friday.

Therefore, this change introduces the concept of 'x days from now'. In addition
to today and tomorrow, users can now specify, for example, 4 days from now for
the scenario described above.
@ldennington
Copy link
Contributor Author

Testing has been on my personal backlog for quite some time, but if you want to give it a try, @ldennington, feel free to suggest something.

I figured it out! I will submit my test workflow as a separate PR, but in my fork I was able to verify the following scenarios:

  • today still works as expected
  • tomorrow still works as expected
  • x days from now works as expected when given a number
  • x days from now falls back to today when not given a number

@ldennington ldennington marked this pull request as ready for review April 2, 2024 17:31
@ldennington ldennington requested a review from stoe as a code owner April 2, 2024 17:31
@stoe stoe enabled auto-merge (squash) April 5, 2024 15:17
@stoe stoe disabled auto-merge April 5, 2024 15:18
@stoe stoe merged commit 74c5c8c into stoe:main Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request 🚧 Want something new?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants