Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inappropriate handling of elm.json for packages #112

Closed
arowM opened this issue Jan 23, 2024 · 2 comments 路 Fixed by #113 or #116
Closed

Inappropriate handling of elm.json for packages #112

arowM opened this issue Jan 23, 2024 · 2 comments 路 Fixed by #113 or #116

Comments

@arowM
Copy link
Contributor

arowM commented Jan 23, 2024

Thanks for the cool project. 馃尫

It seems that the latest v6.0.2 always requires "source-directories" property in elm.json, but elm.json for packages does not have "source-directories" property.
Although it works if we set the "source-directories" property in elm.json for packages, it would be better behavior to check the "type" property and assume that the "source-directories" is ./src if the value is "package".

@stoeffel
Copy link
Owner

Oh yes! good catch! thanks.

bdukes added a commit to EngageSoftware/elm-dnn-http that referenced this issue Jan 24, 2024
bdukes added a commit to EngageSoftware/elm-dnn-localization that referenced this issue Jan 24, 2024
@ymtszw
Copy link
Contributor

ymtszw commented Feb 13, 2024

Attempted a fix (#113), would appreciate your feedback! @stoeffel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants