New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ip-traceable listener #233

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
@alterphp

alterphp commented Mar 30, 2014

Adds support for IpTraceable Gedmo extension

@dev-ish

This comment has been minimized.

Show comment
Hide comment
@dev-ish

dev-ish commented Mar 31, 2014

+1

@lopsided

This comment has been minimized.

Show comment
Hide comment
@lopsided

lopsided commented Apr 1, 2014

+1

@alterphp

This comment has been minimized.

Show comment
Hide comment
@alterphp

alterphp Apr 15, 2014

@stof Any opinion about this PR ?

alterphp commented Apr 15, 2014

@stof Any opinion about this PR ?

Show outdated Hide outdated EventListener/IpTraceListener.php Outdated
Show outdated Hide outdated EventListener/IpTraceListener.php Outdated
Show outdated Hide outdated Resources/config/listeners.xml Outdated
Show outdated Hide outdated EventListener/IpTraceListener.php Outdated
@winzou

This comment has been minimized.

Show comment
Hide comment
@winzou

winzou Apr 22, 2014

👍 but it needs some cleaning, see comments.

winzou commented Apr 22, 2014

👍 but it needs some cleaning, see comments.

Show outdated Hide outdated EventListener/IpTraceListener.php Outdated
@fotomerchant

This comment has been minimized.

Show comment
Hide comment
@fotomerchant

fotomerchant commented Apr 30, 2014

+1

@dirkluijk

This comment has been minimized.

Show comment
Hide comment
@dirkluijk

dirkluijk commented May 11, 2014

+1

@al3d

This comment has been minimized.

Show comment
Hide comment
@al3d

al3d commented May 16, 2014

+1

@oscargala

This comment has been minimized.

Show comment
Hide comment
@oscargala

oscargala commented May 21, 2014

+1

@alterphp

This comment has been minimized.

Show comment
Hide comment
@alterphp

alterphp May 26, 2014

@stof Can you review this PR ?

alterphp commented May 26, 2014

@stof Can you review this PR ?

@dante2008

This comment has been minimized.

Show comment
Hide comment
@dante2008

dante2008 commented Jul 24, 2014

👍

@alterphp

This comment has been minimized.

Show comment
Hide comment
@alterphp

alterphp Aug 19, 2014

Hello @stof

I know you're working on many other projects, I heard about on php-cs-fixer and symfony... But can you review this one please ?

alterphp commented Aug 19, 2014

Hello @stof

I know you're working on many other projects, I heard about on php-cs-fixer and symfony... But can you review this one please ?

@alterphp

This comment has been minimized.

Show comment
Hide comment
@alterphp

alterphp Sep 12, 2014

Hey @stof : any review ?

alterphp commented Sep 12, 2014

Hey @stof : any review ?

@LeoBenoist

This comment has been minimized.

Show comment
Hide comment
@LeoBenoist

LeoBenoist commented Oct 6, 2014

+1

@Axinet

This comment has been minimized.

Show comment
Hide comment
@Axinet

Axinet commented Jan 15, 2015

+1

@alterphp

This comment has been minimized.

Show comment
Hide comment
@alterphp

alterphp commented Feb 22, 2015

UP

@lemoinem

This comment has been minimized.

Show comment
Hide comment
@lemoinem

lemoinem May 5, 2015

👍 Please merge this ASAP...

lemoinem commented May 5, 2015

👍 Please merge this ASAP...

@ConneXNL

This comment has been minimized.

Show comment
Hide comment
@ConneXNL

ConneXNL commented Jun 16, 2015

+1

@guilro

This comment has been minimized.

Show comment
Hide comment
@guilro

guilro commented Jun 22, 2015

+1

Show outdated Hide outdated Resources/config/listeners.xml Outdated
Show outdated Hide outdated Resources/doc/index.rst Outdated
Show outdated Hide outdated EventListener/IpTraceListener.php Outdated
Show outdated Hide outdated EventListener/IpTraceListener.php Outdated
Show outdated Hide outdated DependencyInjection/Configuration.php Outdated
@jdemangeon

This comment has been minimized.

Show comment
Hide comment
@jdemangeon

jdemangeon commented Nov 13, 2015

+1

@Pierstoval

This comment has been minimized.

Show comment
Hide comment
@Pierstoval

Pierstoval Dec 30, 2015

👍 too, I think this can be merged

Pierstoval commented Dec 30, 2015

👍 too, I think this can be merged

@ctaverne

This comment has been minimized.

Show comment
Hide comment
@ctaverne

ctaverne commented Jan 14, 2016

+1 :)

@tkuska

This comment has been minimized.

Show comment
Hide comment
@tkuska

tkuska commented Jan 17, 2016

+1 :)

@alterphp

This comment has been minimized.

Show comment
Hide comment
@alterphp

alterphp Jan 20, 2016

@stof, please accept that. Quicker it will be in the trunk, easier it will be to maintain...

alterphp commented Jan 20, 2016

@stof, please accept that. Quicker it will be in the trunk, easier it will be to maintain...

@Neirda24

This comment has been minimized.

Show comment
Hide comment
@Neirda24

Neirda24 commented Feb 12, 2016

👍

@ctaverne

This comment has been minimized.

Show comment
Hide comment
@ctaverne

ctaverne commented Feb 24, 2016

+1

@alterphp

This comment has been minimized.

Show comment
Hide comment
@alterphp

alterphp Mar 1, 2016

@stof I made some updates in order to enhance Symfony compliance as you told me (even if it breaks bundle uniformity). Please tell me...

alterphp commented Mar 1, 2016

@stof I made some updates in order to enhance Symfony compliance as you told me (even if it breaks bundle uniformity). Please tell me...

@Pierstoval

This comment has been minimized.

Show comment
Hide comment
@Pierstoval

Pierstoval Mar 2, 2016

I'm still 👍 on this feature, now the implementation seems perfect I think it really can be merged 👍

Pierstoval commented Mar 2, 2016

I'm still 👍 on this feature, now the implementation seems perfect I think it really can be merged 👍

@speedy001

This comment has been minimized.

Show comment
Hide comment
@speedy001

speedy001 commented Mar 11, 2016

+1

@alfonmga

This comment has been minimized.

Show comment
Hide comment
@alfonmga

alfonmga Jun 10, 2016

Why this has not been merged yet? any reason?

alfonmga commented Jun 10, 2016

Why this has not been merged yet? any reason?

@lemoinem

This comment has been minimized.

Show comment
Hide comment
@lemoinem

lemoinem Jun 10, 2016

@alfonsomga Because this bundle doesn't seem to be maintained anymore...
You should take a look to https://github.com/KnpLabs/DoctrineBehaviors which offers replacements to several features of Gedmo, with a better architecture most of the time, and actual maintenance.

If you have some time, there are several projects put forward to improve the new library.

lemoinem commented Jun 10, 2016

@alfonsomga Because this bundle doesn't seem to be maintained anymore...
You should take a look to https://github.com/KnpLabs/DoctrineBehaviors which offers replacements to several features of Gedmo, with a better architecture most of the time, and actual maintenance.

If you have some time, there are several projects put forward to improve the new library.

@troymccabe

This comment has been minimized.

Show comment
Hide comment
@troymccabe

troymccabe Oct 17, 2016

Hey @stof,

Any chance you could take a peek & hopefully merge this PR? Been a while :/

Thanks!

troymccabe commented Oct 17, 2016

Hey @stof,

Any chance you could take a peek & hopefully merge this PR? Been a while :/

Thanks!

@ybert

This comment has been minimized.

Show comment
Hide comment
@ybert

ybert Oct 17, 2016

Hey @stof ,
Can you merge this PR? It could be very helpfull for us.
If you think that you will not maintain this bundle, can you give us an alternative?

Thank you for your time.

ybert commented Oct 17, 2016

Hey @stof ,
Can you merge this PR? It could be very helpfull for us.
If you think that you will not maintain this bundle, can you give us an alternative?

Thank you for your time.

@scaytrase

This comment has been minimized.

Show comment
Hide comment
@scaytrase

scaytrase Dec 7, 2016

KnpLabs looks more maintained, but there are not ip_traceable too

scaytrase commented Dec 7, 2016

KnpLabs looks more maintained, but there are not ip_traceable too

@mikysan

This comment has been minimized.

Show comment
Hide comment
@mikysan

mikysan commented Apr 28, 2017

+1

@ceesvanegmond

This comment has been minimized.

Show comment
Hide comment
@ceesvanegmond

ceesvanegmond commented Aug 9, 2017

👍

@Guibzs

This comment has been minimized.

Show comment
Hide comment
@Guibzs

Guibzs commented Sep 2, 2017

+1

@Nek-

This comment has been minimized.

Show comment
Hide comment
@Nek-

Nek- Dec 18, 2017

@alterphp this need a rebase

@stof are you ok with this now?

Nek- commented Dec 18, 2017

@alterphp this need a rebase

@stof are you ok with this now?

@alterphp

This comment has been minimized.

Show comment
Hide comment
@alterphp

alterphp Dec 18, 2017

Nearly 2 years since my last commit... I hope you don't mind if I wait for @stof confirmation before doing anything...

alterphp commented Dec 18, 2017

Nearly 2 years since my last commit... I hope you don't mind if I wait for @stof confirmation before doing anything...

@kyeno

This comment has been minimized.

Show comment
Hide comment
@kyeno

kyeno Apr 23, 2018

...and I stumbled upon this in April 2018, still not merged. Come on...

kyeno commented Apr 23, 2018

...and I stumbled upon this in April 2018, still not merged. Come on...

@emnsen

This comment has been minimized.

Show comment
Hide comment
@emnsen

emnsen Aug 16, 2018

why it can not be merged ?

emnsen commented Aug 16, 2018

why it can not be merged ?

@Nek-

This comment has been minimized.

Show comment
Hide comment
@Nek-

Nek- Aug 19, 2018

It's pretty obvious that stof has no time to maintain this repository more than just "compatiblity with new Sf versions and security fixes".

So if somebody is not happy with that, you can probably enter in discussion in order to fork the repository and maintain it. For example under friendofsymfony organization. Feel free to send some mails to take the temperature of people on the topic.

In any case more talk here is just spam for maintainer(s).

Nek- commented Aug 19, 2018

It's pretty obvious that stof has no time to maintain this repository more than just "compatiblity with new Sf versions and security fixes".

So if somebody is not happy with that, you can probably enter in discussion in order to fork the repository and maintain it. For example under friendofsymfony organization. Feel free to send some mails to take the temperature of people on the topic.

In any case more talk here is just spam for maintainer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment