add php8 support #423
add php8 support #423
Conversation
|
@stof, any update? |
|
Any update on this? |
|
Friendly ping @stof Do you have some time to look at this PR ? Take care |
|
@stof could you please accept this PR? This is the only library keeping most of us from upgrading our projects to PHP 8.0. |
|
It's strange - there is ready PR, without any reaction. |
.travis.yml
Outdated
| @@ -16,7 +17,7 @@ matrix: | |||
| - php: 7.1 | |||
| env: COMPOSER_FLAGS="--prefer-lowest" | |||
| - php: 7.4 | |||
| env: STABILITY=dev | |||
| - php: 8.0 | |||
There was a problem hiding this comment.
Could you please revert this change?
It is not needed, but we should test dev-stability on PHP7.4
There was a problem hiding this comment.
This line can be removed as well. You've added 8.0 in line 8 already, that should be enough.
There was a problem hiding this comment.
done, thanks for review
I don't have permissions on this repo. |
|
Is it possible to tag a new release @stof ? :) |
|
@VincentLanglet Stof hasn't replied for more than a month here. I've tried multiple ways to contact him. See #422 for more information. I even contacted someone from the Symfony Core Team (since symfony.com recommends this bundle), but they're not responsible for third-party bundles. That's why I propose to remove this bundle from the Symfony documentation: symfony/symfony-docs#14909 |
|
@stephanvierkant hi, you're able to use my fork |
|
Thanks! I see it's a popular fork, well done! I think it's in our shared interest to have a well-maintained and community-driven bundle, so feel free to create a PR in |
|
I would recommend just to use that gedmo library directly - it's super easy to use with Symfony 4.x+ - https://github.com/doctrine-extensions/DoctrineExtensions/blob/main/doc/symfony4.md |
Add support for PHP 8.0
#422