Fix config validation exceptions #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C config load. This will need to be done in another compiler pass. Working on that now, but I want to get this committed so our CI server stops complaining about build failures :)
|
Right, using a compiler pass is the good solution. I will wait the complete pull request. I don't have much time at the moment to work on this so thanks to volunteer :) |
(Throws the exceptions removed in 4462128)
|
There's the compiler pass. Like I said, I'm glad to work on it, if it means our CI server will stop complaining :) |
|
Merged. Thanks |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove DBAL connection and Document Manager config validation from DIC config load. This will need to be done in another compiler pass.
I'm working on a compiler pass implementation. I'll add it to this request if I get it done before you pull.