Add NodeName::Block #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoically
reviewed
Jan 3, 2021
stoically
reviewed
Jan 3, 2021
stoically
reviewed
Jan 3, 2021
|
Rebasing on main should also fix the bench CI check |
stoically
force-pushed
the
main
branch
2 times, most recently
from
48d8200
to
4db8ff9
Compare
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
- Coverage 82.91% 82.73% -0.19%
==========================================
Files 4 4
Lines 474 498 +24
==========================================
+ Hits 393 412 +19
- Misses 81 86 +5
Continue to review full report at Codecov.
|
|
Sorry for the mess, Git is definitely not my strength; but I think this fixes those conflicts. |
stoically
approved these changes
Jan 4, 2021
stoically
reviewed
Jan 4, 2021
| @@ -144,6 +153,9 @@ pub enum NodeName { | |||
|
|
|||
| /// Name separated by colons, e.g. `<div on:click={foo} />` | |||
| Colon(Punctuated<Ident, Colon>), | |||
|
|
|||
| /// Arbitrary rust code in braced `{}` blocks | |||
| Block(Expr), | |||
There was a problem hiding this comment.
Just realized, is there a specific reason that this is Expr and not ExprBlock?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was startling that it was so easy to do this, but it passes tests, and actually works as I was hoping it would work in the library I'm building.
Open question how
NodeName::Blockshouldimpl Displaybut it returnsNonefor.name_as_string()so maybe it's not a big deal one way or the other.