-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: Rewrite text for the option to include or not subdomains when creating new containers. #102
Comments
Hey, thanks for the suggestion. I guess you're right that the option texts regarding subdomains could be a bit more explicit. After the refactoring in #91 it won't be called "Isolation" anymore, but instead just "Navigating should open new Temporary Containers" So, how about: Navigating should open new Temporary Containers
Mouse Clicks on Links should open new Temporary Containers
Also, if you have an opinion on the preferences "per website" refactoring here #91 (comment) I'd be interested to hear it too. |
I liked yours text more, but I still think they are too similar to each other. I suggest to make them a single option ("If the clicked Links Domain does not match the current Tabs Domain"), and then show a checkbox to select how to control the subdomains. I have not separated some websites using the custom rules. |
While this is a good idea, the checkbox would need some text to explain what it does too. And if that text explains the behavior well, then it could also just be included in the dropdown instead. :D Maybe: Navigating should open new Temporary Containers
Mouse Clicks on Links should open new Temporary Containers
Also, at some point it might be a good idea to add some documentation and link it in the options, that way a more thorough explanation could be included. |
It also merges the Global Preferences for Isolation and MouseClicks. Thanks in advance! |
Since I decided to keep it "Isolation" as title for the merged tabs I took your suggestion and came up with Navigating
Mouse Clicks
This will be published with the next version. If you have further suggestions feel free to let me know. |
Just published version 0.80 with the changes. Hope you like it. |
On Isolation tab, and mouse clicks tabs, we have:
When navigating in Tabs should open new Temporary Containers:
I found the current text a little confusing.
Just reading them I have no idea if "includes Subdomains" refer to matching also the subdomains (current functionality) or refers to navigation target, and the subdomains would open in a different container (my first guess).
I suggest rewriting them as:
If the navigation target doesn't match the current Tabs Domain (Different Subdomains will be isolated)
If the navigation target doesn't match the current Tabs Domain (Different Subdomains won't be isolated).
Also:
The options for Mouse click > Middle click have a slightly different text.
And finally:
I did not know it was just an html file, and submitted a pull request with this suggestion.
The text was updated successfully, but these errors were encountered: