Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically re-enable Isolation after a delay #315

Closed
mdhooge opened this issue Oct 25, 2019 · 4 comments · Fixed by #429
Closed

Automatically re-enable Isolation after a delay #315

mdhooge opened this issue Oct 25, 2019 · 4 comments · Fixed by #429
Labels
enhancement good first issue

Comments

@mdhooge
Copy link
Contributor

mdhooge commented Oct 25, 2019

If you use this add-on, this is to have Isolation enabled most of the time. When one disables Isolation, this is to prevent the add-on to create a new temporary for a given action…
So it would be nice to be able to define in the options a delay after which the Isolation is enabled again.
Or maybe, a count: “Ignore the next N navigation actions” (with N=1 for most users). But I think this is less intuitive than a 5s delay (for example). Especially when there are a couple of redirections after login in to a site…
@stoically
Copy link
Owner

Would be nice to have indeed.

@mdhooge
Copy link
Contributor Author

mdhooge commented Oct 30, 2019

I'll dive into it as soon as I feel more confident with the code! A lot of JS habits to (re-)discover… 😅
I'm actively on it! 🤞

@stoically
Copy link
Owner

Cool! Let me know if I can be of any help :)

@stoically stoically changed the title New option to automatically re-enable Isolation after a delay Automatically re-enable Isolation after a delay Nov 9, 2019
rkodey added a commit to rkodey/temporary-containers that referenced this issue Jun 21, 2020
@rkodey
feat: automatic re-isolation after n seconds (stoically#315)
8ed969a 
Add handler logic in isolation.ts
Add a new function setIsolation, to consolidate some overlapping code
Replace code in commands.ts with setIsolation function
Update addIsolationInactiveBadge in browseraction.ts to accept an optional counter
@rkodey rkodey mentioned this issue Jun 21, 2020
Merged
rkodey added a commit to rkodey/temporary-containers that referenced this issue Jun 28, 2020
@rkodey
feat: automatic re-isolation after n seconds (stoically#315)
1e86edf 
Adds isolation helpers setActiveState and handleActiveState to consolidate isolation toggle code
Consolidates pageaction.showOrHide into isolation.handleActiveState
Renames members in isolation.ts with a common root autoEnable*
Adds isolation local storage so the auto re-isolation can resume if Firefox closed
Adds tests for isolation active, auto re-isolation, and the toggle_isolation keyboardShortcut
rkodey added a commit to rkodey/temporary-containers that referenced this issue Jun 28, 2020
@rkodey
feat: automatic re-isolation after n seconds (stoically#315)
3b51a89 
Renames autoEnable naming prefix to automaticReactivate to better associate with main "active" var
Removes unneeded comments and debug code
rkodey added a commit to rkodey/temporary-containers that referenced this issue Jun 28, 2020
@rkodey
feat: automatic re-isolation after n seconds (stoically#315)
23243ef 
Removes placeholder comments
rkodey added a commit to rkodey/temporary-containers that referenced this issue Jun 29, 2020
@rkodey
feat: automatic re-isolation after n seconds (stoically#315)
cf4a758 
Updates isolation tests to avoid internal method calls
Clarifies background test descriptions
stoically pushed a commit that referenced this issue Jun 29, 2020
@rkodey
feat: automatic re-isolation after n seconds (#315) (#429)
fbef802 
* feat: automatic re-isolation after n seconds (#315)

Add handler logic in isolation.ts
Add a new function setIsolation, to consolidate some overlapping code
Replace code in commands.ts with setIsolation function
Update addIsolationInactiveBadge in browseraction.ts to accept an optional counter
Adds isolation helpers setActiveState and handleActiveState to consolidate isolation toggle code
Consolidates pageaction.showOrHide into isolation.handleActiveState
Renames members in isolation.ts with a common root autoEnable*
Adds isolation local storage so the auto re-isolation can resume if Firefox closed
Adds tests for isolation active, auto re-isolation, and the toggle_isolation keyboardShortcut
Renames autoEnable naming prefix to automaticReactivate to better associate with main "active" var
Removes unneeded comments and debug code
Removes placeholder comments
Updates isolation tests to avoid internal method calls
Clarifies background test descriptions
rkodey added a commit to rkodey/temporary-containers that referenced this issue Jul 5, 2020
@rkodey
refactor: move isolation.active from preferences to storage
e5a3ab2 
Centralize isolation state management and storage access
Add isolation helper functions getActiveState, toggleActiveState
Retire unneeded helper function handleActiveState
Initialize isolation before browseraction
Related to stoically#315
Closes stoically#433
@rkodey rkodey mentioned this issue Jul 5, 2020
Merged
stoically pushed a commit that referenced this issue Jul 18, 2020
@rkodey
refactor: move isolation.active from preferences to storage (#437)
0448975 
Centralize isolation state management and storage access
Add isolation helper functions getActiveState, toggleActiveState
Retire unneeded helper function handleActiveState
Initialize isolation before browseraction
Related to #315
Closes #433
@stoically
Copy link
Owner

Published v1.9beta2 with the feature, thanks @rkodey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: automatic re-isolation after n seconds (#315) rkodey/temporary-containers
2 participants
@mdhooge @stoically