Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract strings from isolation section for translation (#237) #462

Merged
merged 1 commit into from Sep 15, 2020

Conversation

louix
Copy link
Contributor

@louix louix commented Sep 12, 2020

Wondering if can't use simpler keys (e.g. "mouseClick" over "optionsIsolationMouseClick").

At the moment they give some context, but we could limit use of them to strings only used in once place (e.g. "No Isolated Domains added yet").

We could use the description tag for ambiguous strings, for example:

"save": {
  "message": "Save",
  "description": "verb"
}

Or perhaps even:

"verbSave": {
  "message": "Save"
}

Bit of a pain when you add "optionsIsolationPerDomainMouseClickLeftMouse" and then find it's actually used elsewhere too.

Copy link
Owner

@stoically stoically left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! I'd say we keep the more descriptive ids for now, could always refactor if needed

@stoically stoically merged commit 2f07a09 into stoically:main Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants