Skip to content
This repository has been archived by the owner on Apr 30, 2021. It is now read-only.

Requirement is php 5.3 but you are using some syntax of php 5.4 #9

Closed
vikasbatra opened this issue May 19, 2014 · 6 comments
Closed

Comments

@vikasbatra
Copy link
Collaborator

At some places you are using php 5.4 array syntax and because of that your library doesn't behave well on php 5.3

See array syntax at http://php.net/manual/en/language.types.array.php

You have used [ ] syntax but in php 5.3 this is not supported.

Some places where you have used this syntax is:

stojg/crop/Crop.php on line 182

stojg/crop/CropFace.php on line 91

stojg/crop/CropFace.php on line 115

@stojg
Copy link
Owner

stojg commented May 21, 2014

@jdeniau would you update the composer require or revert back to 5.3 array types?

@vikasbatra
Copy link
Collaborator Author

Should i send you a pull request from my fork or you are giving me write access?

@stojg
Copy link
Owner

stojg commented May 21, 2014

I made you a collaborator, so it's up to you if you want to get a peer review of the changes or just pushing.

However I like you to create a new tag so it's easy for user to lock down the version in composer.

cheers

@vikasbatra
Copy link
Collaborator Author

Changes are done from my side.

@jdeniau
Copy link
Collaborator

jdeniau commented May 21, 2014

Wow it was quick ^^

Thank you for your update.

@vikasbatra
Copy link
Collaborator Author

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants