Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible and simplified folder setup #53

Closed
stojy opened this issue Jan 18, 2023 · 1 comment · Fixed by #56
Closed

More flexible and simplified folder setup #53

stojy opened this issue Jan 18, 2023 · 1 comment · Fixed by #56
Assignees
Labels
enhancement New feature or request

Comments

@stojy
Copy link
Owner

stojy commented Jan 18, 2023

As observed in #52, there are some folders assumptions that need to be cleaned up for a PinballY installation that doesn't use the PinballX folder setup.

Unlike PinballX, PinballY doesn't create it's media and database folders until they're needed. For example, the 'Media\Instruction Cards' folder isn't created until an instruction card is added to a table.

It's a very efficient design, but it causes a few related issues..

  1. Day zero setup - it's not possible to run Scanner or Rebuilder until the folders are created.
  2. Day n+1 setup - if certain features (e.g. instruction cards) are never used, then the folder won't be created.

The workaround is to create these folders manually (an empty directory is fine). The image below shows the required folders in purple.
image

Proposal..

  1. Simplify folder setup. Since the PinballX and PinballY folder structure is nearly identical, only require the top level folder to be specified. For example, "c:\PinballY\Media" and then automatically calculate the other folders.
  2. Cater for missing media sub-folders. Instead of disabling the entire Scanner/Rebuilder feature, just disable the relevant feature for the missing folder.
@stojy stojy self-assigned this Feb 22, 2023
@stojy stojy added the enhancement New feature or request label Feb 22, 2023
@stojy stojy pinned this issue Feb 22, 2023
@stojy stojy unpinned this issue Feb 22, 2023
@stojy stojy pinned this issue Mar 6, 2023
@stojy stojy linked a pull request Mar 11, 2023 that will close this issue
@stojy stojy closed this as completed in #56 Mar 11, 2023
@stojy
Copy link
Owner Author

stojy commented Mar 11, 2023

Implemented proposal 2 to cater for missing sub-folders by making the majority of them optional. Only the following folders are mandatory..

  • tables
  • frontend database

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant