Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listitem.episode and listitem.premiered to List view for Addons #258

Closed
jingai opened this issue Nov 17, 2014 · 9 comments
Closed

Add listitem.episode and listitem.premiered to List view for Addons #258

jingai opened this issue Nov 17, 2014 · 9 comments
Milestone

Comments

@jingai
Copy link
Collaborator

jingai commented Nov 17, 2014

Show the Episode Number and Air Date of items for addons.

@jingai jingai added this to the 3.1.0 milestone Nov 17, 2014
@jingai jingai modified the milestones: 3.1.0, 3.1.1 Dec 26, 2014
@jingai jingai modified the milestones: 3.1.1, 3.1.0 Jan 14, 2015
@jingai
Copy link
Collaborator Author

jingai commented Jan 14, 2015

See something like the Tekzilla show in the Revision3 addon in Confluence's 'Media Info' view for an example of this.

@jingai jingai modified the milestones: 3.1.0, 3.0.2 Jan 14, 2015
@MacGyverr
Copy link
Contributor

The issue is that Kodi creates the episode info straight into the ListItem.Label, you can create a similar view by piecing it together from elements, but it requires a lot of conditionals.

@jingai
Copy link
Collaborator Author

jingai commented Jan 19, 2015

Yeah, I remembered this after I looked at it again the other day.. I would like to offer more views and information for addons, but it's seriously difficult to test all of the conditions since all addons seem to provide similar content in different ways..

@MacGyverr
Copy link
Contributor

Maybe some conditional variables could work their magic. You know what I mean, build one view, and just define the labels and textures separate. The code is smaller, and allows for adding new elements quicker. (no rewrites for every new thing)

@jingai
Copy link
Collaborator Author

jingai commented Jan 19, 2015

Aye, I'll be looking at it closely since I want to make the data displayed as uniform as possible across all views anyway.

@jingai jingai modified the milestones: 3.0.2, 3.0.3 Jan 30, 2015
@jingai jingai changed the title Add listitem.episode and listitem.premiered to List view Add listitem.episode and listitem.premiered to List view for Addons Feb 2, 2015
@jingai jingai modified the milestones: 3.0.3, 3.0.2 Feb 2, 2015
@jingai
Copy link
Collaborator Author

jingai commented Feb 2, 2015

Really this whole problem would go away if addon developers would just flag their freaking content correctly..

@jingai
Copy link
Collaborator Author

jingai commented Feb 3, 2015

Pushing this off.. I know Confluence has workarounds in place for this, but I really think these kinds of workarounds belong in the addons (i.e., setting the current content type correctly). Not going to close the issue.. but I'd rather not prioritize it either since it really feels like a Not My Problem kind of thing.

@jingai jingai added this to the 3.2.0 milestone Feb 3, 2015
@jingai jingai removed this from the 3.0.3 milestone Feb 3, 2015
@jingai
Copy link
Collaborator Author

jingai commented Feb 3, 2015

To add to this, look at the YouTube addon as an example of one that does it correctly.

jingai added a commit that referenced this issue Feb 4, 2015
jingai added a commit that referenced this issue Feb 4, 2015
@jingai
Copy link
Collaborator Author

jingai commented Feb 4, 2015

Ok, I caved. It will show the episode on the list item now, but.. there are now some shows within addons that set both season and episode to 1 (or some arbitrary value) for everything.. so prepare for that backlash I guess.

Fix it for some and break it for others.. ultimately though, this is up to the addon authors to deal with. The way I'm handling it now is proper.

Reports of superfluous and incorrect season/episode numbers on the items I can at least now just pass the buck to the addon author.

@jingai jingai modified the milestones: 3.0.3, 3.2.0 Feb 4, 2015
@jingai jingai closed this as completed Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants