Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for OpenWeatherMap maps #278

Closed
jingai opened this issue Nov 18, 2014 · 8 comments
Closed

Support for OpenWeatherMap maps #278

jingai opened this issue Nov 18, 2014 · 8 comments
Milestone
2.9.1

Comments

@jingai
Copy link
Collaborator

jingai commented Nov 18, 2014

No description provided.

@jingai jingai added this to the 2.9.1 milestone Nov 18, 2014
@MacGyverr
Copy link
Contributor

https://github.com/MacGyverr/Metropolis/commit/a0e494fd8b64f6cd97ad9650c05f1562761577e3
https://github.com/MacGyverr/Metropolis/commit/85745c8c71baab3e54c391101335bbc66af2fcbd
https://github.com/MacGyverr/Metropolis/commit/f938cb43c571d6c13e23639f04cd156e12df50da
screenshot010

@MacGyverr
Copy link
Contributor

For Helix:
https://github.com/MacGyverr/Metropolis/commit/062c21615ff17dba04b134b9f1cddfa742f3ee4e
screenshot002

@jingai
Copy link
Collaborator Author

jingai commented Dec 26, 2014

Why only Helix for 062c216?

jingai added a commit that referenced this issue Dec 26, 2014
@jingai
Add Weather Maps.
2e6b5e8 
Thanks again to MacGyver.

Addresses Issue #278.
jingai added a commit to jingai/skin.metropolis that referenced this issue Dec 26, 2014
@jingai
Add Weather Maps.
6bedaf8 
Thanks again to MacGyver.

Addresses Issue stoli#278.
@MacGyverr
Copy link
Contributor

The Gotham one was in 3 stages, Helix was just a replacement of the 1 final file.

@jingai
Copy link
Collaborator Author

jingai commented Dec 27, 2014

Ok, just making sure. The Gotham version of OpenWeatherMap Extended addon appears to be missing a couple of labels.. probably a bug in the addon, not sure..

@MacGyverr
Copy link
Contributor

Yep, the same code works fine on Helix, and the other skins are missing them too. It can be quasi fixed by using a "fallback" label.

@jingai
Copy link
Collaborator Author

jingai commented Dec 27, 2014

Yeah, I had considered that.. I'll look into it a bit more first though, just in case those two that are missing labels aren't supposed to be there for the Gotham version.

@jingai
Copy link
Collaborator Author

jingai commented Dec 28, 2014

Going to put this in as-is. It's a minor issue that maybe the addon author will address at some point. Moving on to Helix now..

@jingai jingai closed this as completed Dec 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.1
Development

No branches or pull requests
2 participants
@jingai @MacGyverr