Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore creds first , managed clusters last #455

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

birsanv
Copy link
Collaborator

@birsanv birsanv commented Dec 5, 2023

https://issues.redhat.com/browse/ACM-8857

Create velero Restore for credentials first
Create ManagedClusters restore last
Screen Shot 2023-12-05 at 4 15 51 PM

Resources restored after credentials
Screen Shot 2023-12-05 at 4 16 01 PM

Then managed clusters
Screen Shot 2023-12-05 at 4 16 35 PM

Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
Signed-off-by: Valentina Birsan <vbirsan@redhat.com>
Copy link
Collaborator

@tesshuflower tesshuflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: birsanv, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [birsanv,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@openshift-merge-bot openshift-merge-bot bot merged commit ab8424d into stolostron:main Dec 6, 2023
6 checks passed
@birsanv
Copy link
Collaborator Author

birsanv commented Dec 6, 2023

/cherry-pick release-2.9

@birsanv birsanv deleted the vb_creds_restore branch December 6, 2023 17:33
@openshift-cherrypick-robot

@birsanv: new pull request created: #457

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@birsanv
Copy link
Collaborator Author

birsanv commented Dec 6, 2023

/cherry-pick release-2.8

@birsanv
Copy link
Collaborator Author

birsanv commented Dec 6, 2023

/cherry-pick release-2.7

@openshift-cherrypick-robot

@birsanv: new pull request created: #458

In response to this:

/cherry-pick release-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@birsanv: new pull request created: #459

In response to this:

/cherry-pick release-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants