Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix statuses #1523

Merged
merged 11 commits into from Apr 13, 2022
Merged

fix statuses #1523

merged 11 commits into from Apr 13, 2022

Conversation

jeswanke
Copy link
Contributor

@jeswanke jeswanke commented Apr 8, 2022

Signed-off-by: John Swanke jswanke@redhat.com

Signed-off-by: John Swanke <jswanke@redhat.com>
fxiang1
fxiang1 previously approved these changes Apr 8, 2022
Copy link
Contributor

@fxiang1 fxiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks John!

Signed-off-by: John Swanke <jswanke@redhat.com>
fxiang1
fxiang1 previously approved these changes Apr 8, 2022
Copy link
Contributor

@fxiang1 fxiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: John Swanke <jswanke@redhat.com>
fxiang1
fxiang1 previously approved these changes Apr 8, 2022
Copy link
Contributor

@fxiang1 fxiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
Signed-off-by: John Swanke <jswanke@redhat.com>
@jeswanke jeswanke requested a review from fxiang1 April 11, 2022 12:50
Copy link
Contributor

@fxiang1 fxiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 11, 2022
@openshift-ci
Copy link

openshift-ci bot commented Apr 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1, jeswanke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fxiang1
Copy link
Contributor

fxiang1 commented Apr 12, 2022

/retest

1 similar comment
@fxiang1
Copy link
Contributor

fxiang1 commented Apr 12, 2022

/retest

@droslean
Copy link

/test lint-check-unittests-sonarcloud

@droslean
Copy link

/test pr-image-mirror-mce

@sonarcloud
Copy link

sonarcloud bot commented Apr 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

56.9% 56.9% Coverage
1.8% 1.8% Duplication

@openshift-merge-robot openshift-merge-robot merged commit bd49992 into stolostron:main Apr 13, 2022
@jeswanke jeswanke deleted the testingit branch November 17, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants