Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieving the policy template details in hosted mode #1966

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Aug 8, 2022

In hosted mode, the cluster where the policy templates exist is
different than the managed cluster that the policy templates apply to.
This commit accounts for this when the Policy addon is installed in
hosted mode.

Relates:
https://github.com/stolostron/backlog/issues/24919
https://github.com/stolostron/backlog/issues/23723

JustinKuli
JustinKuli previously approved these changes Aug 8, 2022
Copy link
Contributor

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

In hosted mode, the cluster where the policy templates exist is
different than the managed cluster that the policy templates apply to.
This commit accounts for this when the Policy addon is installed in
hosted mode.

Relates:
stolostron/backlog#24919
stolostron/backlog#23723

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@mprahl
Copy link
Contributor Author

mprahl commented Aug 8, 2022

/cc @jamestalton
/cc @KevinFCormier

@openshift-ci openshift-ci bot added the lgtm label Aug 8, 2022
Copy link
Contributor

@ChunxiAlexLuo ChunxiAlexLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ChunxiAlexLuo
Copy link
Contributor

/assign @showeimer

@ChunxiAlexLuo
Copy link
Contributor

/cc @Randy424

@openshift-ci openshift-ci bot requested a review from Randy424 August 9, 2022 15:51
Copy link
Contributor

@robdolares robdolares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChunxiAlexLuo, JustinKuli, mprahl, RobDolares

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mprahl
Copy link
Contributor Author

mprahl commented Aug 10, 2022

/cherry-pick release-2.6

@openshift-cherrypick-robot
Copy link
Contributor

@mprahl: once the present PR merges, I will cherry-pick it on top of release-2.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mprahl
Copy link
Contributor Author

mprahl commented Aug 10, 2022

/retest

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.2% 85.2% Coverage
0.0% 0.0% Duplication

@openshift-merge-robot openshift-merge-robot merged commit 145ba0d into stolostron:main Aug 10, 2022
@openshift-cherrypick-robot
Copy link
Contributor

@mprahl: new pull request created: #1987

In response to this:

/cherry-pick release-2.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants