Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the related objects view YAML link in hosted mode #1996

Merged

Conversation

mprahl
Copy link
Contributor

@mprahl mprahl commented Aug 15, 2022

In hosted mode, the cluster where the policy templates exist is
different than the managed cluster that the policy templates apply to.
This commit accounts for this when the Policy addon is installed in
hosted mode.

Now the "View yaml" link will search for the related object on the
managed cluster instead of the hosting cluster.

Relates:
https://github.com/stolostron/backlog/issues/25103
https://bugzilla.redhat.com/show_bug.cgi?id=2118338

Signed-off-by: mprahl mprahl@users.noreply.github.com

In hosted mode, the cluster where the policy templates exist is
different than the managed cluster that the policy templates apply to.
This commit accounts for this when the Policy addon is installed in
hosted mode.

Now the "View yaml" link will search for the related object on the
managed cluster instead of the hosting cluster.

Relates:
stolostron/backlog#25103
https://bugzilla.redhat.com/show_bug.cgi?id=2118338

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
@mprahl
Copy link
Contributor Author

mprahl commented Aug 15, 2022

/assign @jamestalton
/assign @KevinFCormier
/assign @robdolares

@sonarcloud
Copy link

sonarcloud bot commented Aug 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@KevinFCormier
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 63b139c into stolostron:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants