Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AWS hypershift cluster HostedCluster details not displaying #2213

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

fxiang1
Copy link
Contributor

@fxiang1 fxiang1 commented Oct 28, 2022

Signed-off-by: Feng Xiang fxiang@redhat.com

https://issues.redhat.com/browse/ACM-1606

  • Fixed Hypershift cluster detection to use new annotation
  • Fixed degraded false status to not show error icon

image

Signed-off-by: Feng Xiang <fxiang@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.5% 89.5% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@chenz4027 chenz4027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenz4027, fxiang1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 421cac7 into stolostron:main Oct 28, 2022
@fxiang1 fxiang1 deleted the feng-hsbug branch October 28, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants