ACM-9431 - Auto import discovered ROSA clusters

[Randy424]

Regarding: https://issues.redhat.com/browse/ACM-9431

To test:

1. In multicloud/credentials, setup OCM discovery credentials. You will need discoverable and importable ROSA and OCP clusters in your OCM environment.
2. Go to the discovery tab (multicloud/infrastructure/clusters/discovered).
3. Click the action menu (kebab menu) for your ROSA/OCP cluster and click Import cluster.
4. For ROSA, import mode "Import from Red Hat OpenShift Cluster Manager" should be set, the cluster information should be pre-filled. Credential, ClusterID and Api token fields should be present.
5. For OCP import mode "Enter your server URL and API token for the existing cluster" should be set.
6. For Import cluster from the cluster list page (not from a discovered cluster), the import mode should be manual.

[Randy424]

/hold

[KevinFCormier]

Awesome work! It works great. I left a few comments about code organization. There are also a couple functional issues we might want to address.

1. Credential should include the namespace, as it does in the configuration screens. (See screenshots.)
2. I think we should avoid passing the credential and the cluster ID to the form for non-ROSA clusters. If the user changes to use the RHOCM import mode and sees the pre-filled information, they might expect it to work.

[Randy424]

/retest

[Randy424]

Currently making these changes: #3507 (review), will update thread when they're completed.

[Randy424]

Awesome work! It works great. I left a few comments about code organization. There are also a couple functional issues we might want to address.

1. Credential should include the namespace, as it does in the configuration screens. (See screenshots.)
2. I think we should avoid passing the credential and the cluster ID to the form for non-ROSA clusters. If the user changes to use the RHOCM import mode and sees the pre-filled information, they might expect it to work.

@KevinFCormier
I've made some changes to try and adopt the behavior of the discovery configuration wizard, but it looks like react-form-wizard does not support the kind of field validation I am trying to enforce. Namely, I'm not sure how I can prevent users from progressing in the wizard when the credential field is empty. The react-form-wizard exposes it's validation context to its proprietary components, and if I want to use a proprietary component it needs a path that corresponds to the template data. I am using fields that don't have a place within the template (won't have a path value) but still need to block the users progression when they are empty, as to mirror the validation of the other fields. It looks like the import mode field has this same issue, but we don't notice it because it always contains a value.

[Randy424]

/retest

[Randy424]

@KevinFCormier This is ready for re-review! Thanks.

[Randy424]

https://github.com/stolostron/console/compare/1168adddd0d4d57c57bc0a74407f92798ebea3f9..ccbacaaf70f287c5d2c4bd3ed1e1ee59941c726d#diff-8a926d9ebe0a8a54381ef56ca3f270e5206bd156cfc55418093676894c5a509dL177-L181

This was handing values to namespace, credential and clusterID during regular import (no initial discovery cluster).

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[KevinFCormier]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinFCormier, Randy424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KevinFCormier,Randy424]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment