Update Gatekeeper CRD descriptions #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaiducek
force-pushed
the
8992-api-descriptions
branch
from
3dc6e88
to
85cbf6b
Compare
JustinKuli
previously approved these changes
Apr 2, 2024
dhaiducek
dismissed stale reviews from yiraeChristineKim and JustinKuli
via
ce50453
dhaiducek
force-pushed
the
8992-api-descriptions
branch
from
85cbf6b
to
ce50453
Compare
dhaiducek
force-pushed
the
8992-api-descriptions
branch
2 times, most recently
from
428b283
to
7e88ca0
Compare
dockerymick
suggested changes
Apr 2, 2024
bundle/manifests/gatekeeper-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
bundle/manifests/gatekeeper-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
bundle/manifests/gatekeeper-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
bundle/manifests/gatekeeper-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
bundle/manifests/gatekeeper-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
bundle/manifests/gatekeeper-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
bundle/manifests/gatekeeper-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
config/manifests/bases/gatekeeper-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
dhaiducek
force-pushed
the
8992-api-descriptions
branch
3 times, most recently
from
b86ca73
to
c0cea55
Compare
mprahl
reviewed
Apr 2, 2024
mprahl
reviewed
Apr 2, 2024
mprahl
reviewed
Apr 2, 2024
mprahl
reviewed
Apr 2, 2024
dhaiducek
force-pushed
the
8992-api-descriptions
branch
2 times, most recently
from
4892fee
to
0a63cf8
Compare
dockerymick
suggested changes
Apr 3, 2024
ref: https://issues.redhat.com/browse/ACM-8992 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
8992-api-descriptions
branch
from
0a63cf8
to
bd88c1f
Compare
|
dockerymick
approved these changes
Apr 3, 2024
mprahl
approved these changes
Apr 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, dockerymick, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
Thanks for all the reviews, everyone! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This represents a major update to the descriptions and reorganization of the
*_types.gofile, placing dependent structs higher in the file (and closer to structs that require them where relevant). I couldn't find wherestatuswas even used, so I've gutted it. I can revert that if there are concerns, but it seemed relatively safe since the operator should be the only thing populating it. I also made an effort to link to the upstream Gatekeeper docs wherever possible, which I think will go a long way toward enabling serviceability and helpfulness of the operator configuration.ref: https://issues.redhat.com/browse/ACM-8992