Restrict lookups of cluster-scoped resources #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
reviewed
Jun 13, 2023
pkg/templates/generic_lookup_func.go
Outdated
| if !apiResource.Namespaced && t.config.LookupNamespace != "" { | ||
| rsrcIdentifier := ClusterScopedObjectIdentifier{ | ||
| Group: apiResource.Group, | ||
| Version: apiResource.Version, |
There was a problem hiding this comment.
I don't think the version should be used in the restriction. For instance, if ClusterClaim has an API version bump, I wouldn't want the calling code to be updated.
There was a problem hiding this comment.
That's a good point.
mprahl
reviewed
Jun 13, 2023
pkg/templates/generic_lookup_func.go
Outdated
| } | ||
|
|
||
| for _, item := range allowlist { | ||
| if item.Group == "*" && item.Version == "*" && item.Kind == "*" && item.Name == "*" { |
There was a problem hiding this comment.
I think something like this would be better:
if item.Group != "*" && item.Group != rsrc.Group {
continue
}
if item.Kind != "*" && item.Kind != rsrc.Kind {
continue
}
if item.Name == "*" || item.Name == rsrc.Name {
return true
}
mprahl
requested changes
Jun 13, 2023
In some cases, it was possible to do a cluster-scoped lookup, despite `LookupNamespace` being set on the config, which was intended to prevent this. That is fixed, and more thoroughly tested. A new config field `ClusterScopedAllowList` was added to allow specific cluster-scoped resources to be used in `lookup` when `LookupNamespace` is set. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
limit-clusterscoped-lookup
branch
from
d71ef30
to
76beeea
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, it was possible to do a cluster-scoped lookup, despite
LookupNamespacebeing set on the config, which was intended to prevent this. That is fixed, and more thoroughly tested.A new config field
ClusterScopedAllowListwas added to allow specific cluster-scoped resources to be used inlookupwhenLookupNamespaceis set.