Add two caching modes #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
force-pushed
the
caching
branch
6 times, most recently
from
75ab9dc
to
40cce6f
Compare
JustinKuli
reviewed
Oct 17, 2023
mprahl
force-pushed
the
caching
branch
2 times, most recently
from
74891a9
to
2d4f766
Compare
The default caching mode is one that caches objects for the duration of the ResolveTemplate execution. This mode is not completely concurrency safe. The advanced caching mode is concurrency safe and utilizes watches to update the cache in background goroutines. The resolve options are now passed to the ResolveTemplate method. This allows a shared resolver to resolve templates for different propagated policies. This allows the cache to be shared as well. Relates: https://issues.redhat.com/browse/ACM-7398 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
This is useful in the OCM Policy Propagator, where the ManagedClusterLabels variable is set from the ManagedCluster object the replicated policy is being built for. Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Signed-off-by: mprahl <mprahl@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit for changes.
The default caching mode is one that caches objects for the duration of the ResolveTemplate execution. This mode is not completely concurrency safe.
The advanced caching mode is concurrency safe and utilizes watches to update the cache in background goroutines.
Relates:
https://issues.redhat.com/browse/ACM-7398