Startup probes #60
Merged
Startup probes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The startupProbes will help prevent a slow API discovery from sending the containers into CrashLoopBackOff. On clusters where startupProbes might not be available (pre k8s 1.20), we have to use an equivalent initialDelaySeconds parameter. In order to restart the pods more quickly on the managed clusters, especially during testing, this also updates the deployment strategy to "Recreate". Thus it will not wait for the previous deployment to become ready before deleting it, which would take a minimum of 5 minutes on older k8s clusters. Refs: - stolostron/backlog#23874 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 918eeb7739f8db71f386068ac7eb236aac2c3859)
This was somehow missing - now the KinD tests Github Action will run on multiple kubernetes versions. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit d4264201d96a70ee529c3cda060331b645aa6aad)
Depending on the k8s version, the chart should render these differently. The existing KinD tests should exercise both paths (in separate runs). Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 2b45b54a89c664239cd910f1be1dea27b7d70104)
Some stuff was failing on v1.18, but didn't fail locally with 1.19. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit d9d1d8883885f26eb06bb7e8f3a5dbc986fe791c)
There were many instances where `unstructured.Nested*` methods could be used for better safety (preventing panics if types failed to be converted). Additionally, this removes the 5 minute wait for the new config-policy rollout, in favor of an `Eventually` section that doesn't wait for the pod to become fully Ready. We really only care how it's configured, which we can check without that wait. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 07444da68ca4a8248bec094efdea34539463ea11)
|
Closes #59 |
mprahl
approved these changes
Jul 11, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/cherrypick release-2.5 |
|
@JustinKuli: #60 failed to apply on top of branch "release-2.5": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking open-cluster-management-io/governance-policy-addon-controller#10
Fixes part of https://github.com/stolostron/backlog/issues/24148