Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃 Sync from open-cluster-management-io/governance-policy-propagator: #222 #727

Merged
merged 1 commit into from
May 22, 2024

Conversation

magic-mirror-bot[bot]
Copy link
Contributor

Remove case 19 that is checking reconcile numbers because this test is flaky, and hard to reset the metrics, we already verified our reconcile work properly
Signed-off-by: yiraeChristineKim <yikim@redhat.com>
(cherry picked from commit bceafae69bc20b701ba3e00d179fd86462aadffb)
Copy link

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign gparvin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@magic-mirror-bot magic-mirror-bot bot merged commit b5e5d3f into main May 22, 2024
16 of 17 checks passed
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1716389101099 branch May 22, 2024 15:10
@dhaiducek
Copy link
Contributor

/cherry-pick release-2.10

@openshift-cherrypick-robot

@dhaiducek: new pull request created: #737

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants