requeue reconcile for klusterlet secrets

[rokej]

Signed-off-by: Roke Jung roke@redhat.com

Description of the change(s):

• When the agent reconcile fails to create external-managed-kubeconfig secret in the hosted cluster's klusterlet namespace or hub mirror secret, requeue the reconcile until it succeeds.

Why do we need this PR:

• This fixes the current assumption that the klusterlet is available when the hosted control plane becomes available.
• This fixes the current assumption that a managed cluster is created before a hosted cluster.

Issue reference:

• https://issues.redhat.com/browse/ACM-2208

Test API/Unit - Success

KUBEBUILDER_ASSETS="/Users/rokej/Library/Application Support/io.kubebuilder.envtest/k8s/1.22.1-darwin-amd64" go test github.com/stolostron/hypershift-addon-operator/cmd github.com/stolostron/hypershift-addon-operator/pkg/agent github.com/stolostron/hypershift-addon-operator/pkg/install github.com/stolostron/hypershift-addon-operator/pkg/manager github.com/stolostron/hypershift-addon-operator/pkg/metrics github.com/stolostron/hypershift-addon-operator/pkg/util -coverprofile cover.out
?   	github.com/stolostron/hypershift-addon-operator/cmd	[no test files]
ok  	github.com/stolostron/hypershift-addon-operator/pkg/agent	15.990s	coverage: 71.6% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/install	147.267s	coverage: 86.3% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/manager	1.341s	coverage: 56.0% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/metrics	0.541s	coverage: 100.0% of statements
?   	github.com/stolostron/hypershift-addon-operator/pkg/util	[no test files]

[mikeshng]

Just some minor feedback. Good otherwise.

[mikeshng]

/approve

/lgtm

[mikeshng]

@rokej I suggested this line

c.log.Error(err, "failed to find the klusterlet namespace: %s", klusterletNamespaceNsn.Name)

based on the other c.log.Error lines in the function. I am guessing they are all invalid and we just never ran into them because we didn't have test or run into them during runtime.

I think we should fix them all. Maybe something like this:

c.log.Error(err, fmt.Sprintf("failed to find the klusterlet namespace: %s", klusterletNamespaceNsn.Name))

or

c.log.Error(err, "failed to find the klusterlet namespace: " + klusterletNamespaceNsn.Name)

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

44.4% Coverage
0.0% Duplication

[openshift-ci]

@rokej: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/sonar	fb4d03b	link	true	/test sonar

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mikeshng]

/approve

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikeshng, rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rokej]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rokej]

Cannot cover log message tests. Force merging.