New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLO metrics #218

Merged

rokej merged 1 commit into stolostron:backplane-2.2 from rokej:slo_metrics_2.2

Mar 22, 2023

Contributor

rokej commented Mar 22, 2023 •

edited

Description of the change(s):

Fix the code that assumes all HCs have kubeadmin-password secret
Generate metrics data to calculate reconcile error rate

Why do we need this PR:

To generate the overall SLO of the agent that takes part in HC creations

Issue reference:

https://issues.redhat.com/browse/ACM-4447

Test API/Unit - Success

?   	github.com/stolostron/hypershift-addon-operator/cmd	[no test files]
ok  	github.com/stolostron/hypershift-addon-operator/pkg/agent	34.390s	coverage: 74.1% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/install	281.406s	coverage: 87.0% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/manager	1.233s	coverage: 56.2% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/metrics	0.519s	coverage: 100.0% of statements
?   	github.com/stolostron/hypershift-addon-operator/pkg/util	[no test files]


          add SLO metrics

7c558e4

Signed-off-by: Roke Jung <roke@redhat.com>

rokej changed the base branch from main to backplane-2.2

March 22, 2023 21:58

openshift-ci bot commented Mar 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rokej]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

sonarcloud bot commented Mar 22, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

88.0% Coverage
0.0% Duplication

Contributor Author

rokej commented Mar 22, 2023

/test e2e

1 similar comment

Contributor Author

rokej commented Mar 22, 2023

/test e2e

rokej merged commit 53cda07 into stolostron:backplane-2.2

rokej deleted the slo_metrics_2.2 branch

March 22, 2023 23:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment