Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backup restore, canary test and install job retention #220

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix backup restore, canary test and install job retention #220

merged 1 commit into from
Mar 30, 2023

Conversation

rokej
Copy link
Contributor

@rokej rokej commented Mar 30, 2023

Description of the change(s):

  • When a managed cluster is restored to a DR hub, detect the change in the hub kubeconfig and restart the agent to pick up the new hub's kubeconfig for API connection
  • Fix the condition check for HO reinstallation
  • Fix canary test
  • Change the HO installation job TTL from 20 minutes to 48 hours to give SREs enough time for troubleshooting

Why do we need this PR:

  • Backup and restore
  • Tests
  • Troubleshooting ability

Issue reference:

Test API/Unit - Success

n-operator/pkg/util -coverprofile cover.out
?   	github.com/stolostron/hypershift-addon-operator/cmd	[no test files]
ok  	github.com/stolostron/hypershift-addon-operator/pkg/agent	29.482s	coverage: 71.3% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/install	176.019s	coverage: 86.0% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/manager	121.397s	coverage: 60.2% of statements
ok  	github.com/stolostron/hypershift-addon-operator/pkg/metrics	0.967s	coverage: 100.0% of statements
?   	github.com/stolostron/hypershift-addon-operator/pkg/util	[no test files]

Signed-off-by: Roke Jung <roke@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rokej

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

52.6% 52.6% Coverage
0.0% 0.0% Duplication

@openshift-ci
Copy link

openshift-ci bot commented Mar 30, 2023

@rokej: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonar ec3c89a link true /test sonar

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rokej rokej merged commit 3258c7c into stolostron:main Mar 30, 2023
@rokej rokej deleted the backup-restore branch March 30, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant