Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Patch instead of Update for HostedCluster Objects #243

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

davidvossel
Copy link
Contributor

The HypershiftAddonOperator is using an outdated version of the HostedCluster API. The result is when this controller performs an Update on a HC, some new fields get dropped that this controller has no knowledge of.

One way to prevent this moving forward is to always use a Patch operation on objects owned by other controllers (like the HostedCluster object).

Test API/Unit - Success


Signed-off-by: David Vossel <davidvossel@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: davidvossel
Once this PR has been reviewed and has the lgtm label, please assign philipwu08 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Jun 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rokej
Copy link
Contributor

rokej commented Jun 6, 2023

/test e2e

@davidvossel
Copy link
Contributor Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 6, 2023

@davidvossel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 7fadffe link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rokej
Copy link
Contributor

rokej commented Jun 6, 2023

The e2e test failure is unrelated to this code change. The code change is manually verified.

@rokej rokej merged commit e920ede into stolostron:main Jun 6, 2023
7 of 9 checks passed
rokej added a commit that referenced this pull request Jun 6, 2023
Signed-off-by: David Vossel <davidvossel@gmail.com>
Co-authored-by: David Vossel <davidvossel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants